[misc] refactor: refactor the folders structure#3
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the repository to rename the core package from verl to verl_omni, focusing on RL training for diffusion and omni-modality models. The changes include comprehensive updates to imports, configuration paths, and project metadata, as well as the removal of legacy PPO configurations. Feedback indicates that version requirements for tensordict, vllm, and verl appear incorrect or refer to non-existent public versions, which could lead to installation failures. Additionally, a suggestion was made to update the import path for TrainingWorkerConfig in the test suite to maintain consistency with the new package structure.
| parent.diffusers_impl = _omni_impl | ||
|
|
||
|
|
||
| def apply_patches() -> None: |
There was a problem hiding this comment.
Maybe we can add log info here, to remind dropping these patches in future version
| cachetools | ||
| codetiming | ||
| datasets | ||
| diffusers |
| __version__ = f.read().strip() | ||
|
|
||
| install_requires = [ | ||
| "verl>=0.7.1", |
There was a problem hiding this comment.
did you try to install in this way?
There was a problem hiding this comment.
No, we hold a temporally version here. I think it should be formally supported with 0.8.0?
What does this PR do?
verldependencyChecklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,vllm_omni,rollout,trainer,ci,training_utils,recipe,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,diffusion,omni,tests,docker,like[diffusion, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][diffusion, fsdp] feat: new rollout schedulerTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always