Skip to content

[misc] refactor: refactor the folders structure#3

Merged
SamitHuang merged 16 commits into
mainfrom
refactor_folder
Apr 22, 2026
Merged

[misc] refactor: refactor the folders structure#3
SamitHuang merged 16 commits into
mainfrom
refactor_folder

Conversation

@zhtmike
Copy link
Copy Markdown
Collaborator

@zhtmike zhtmike commented Apr 22, 2026

What does this PR do?

  1. refactor the folders strcutures, add verl dependency

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, vllm_omni, rollout, trainer, ci, training_utils, recipe, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward, diffusion, omni, tests, docker
    • If this PR involves multiple modules, separate them with , like [diffusion, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][diffusion, fsdp] feat: new rollout scheduler

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

  • Read the Contribute Guide.
  • Apply pre-commit checks: pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always
  • Add / Update the documentation.
  • Add unit or end-to-end test(s) to the CI workflow to cover all the code. If not feasible, explain why: ...

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the repository to rename the core package from verl to verl_omni, focusing on RL training for diffusion and omni-modality models. The changes include comprehensive updates to imports, configuration paths, and project metadata, as well as the removal of legacy PPO configurations. Feedback indicates that version requirements for tensordict, vllm, and verl appear incorrect or refer to non-existent public versions, which could lead to installation failures. Additionally, a suggestion was made to update the import path for TrainingWorkerConfig in the test suite to maintain consistency with the new package structure.

Comment thread setup.py
Comment thread requirements.txt
Comment thread tests/models/test_diffusers_fsdp_engine.py
@zhtmike zhtmike changed the title refactor the folders strcutures [misc] refactor: refactor the folders structure Apr 22, 2026
Comment thread verl_omni/_patch.py
parent.diffusers_impl = _omni_impl


def apply_patches() -> None:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add log info here, to remind dropping these patches in future version

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread requirements.txt Outdated
cachetools
codetiming
datasets
diffusers
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify the version?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread setup.py Outdated
__version__ = f.read().strip()

install_requires = [
"verl>=0.7.1",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try to install in this way?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we hold a temporally version here. I think it should be formally supported with 0.8.0?

@SamitHuang SamitHuang merged commit 411d1d6 into main Apr 22, 2026
4 checks passed
@zhtmike zhtmike deleted the refactor_folder branch April 23, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants