-
Notifications
You must be signed in to change notification settings - Fork 0
Complete rewrite of linting setup #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 93 commits
624a3c6
a65ffe0
0448691
f63a02f
29db48d
bae57e0
c3c086b
03956d4
4f04d1a
c35e249
65518ad
71e04a5
66ef523
db3e785
0f213b2
3b74be6
2f154c8
d945b9e
da10469
97c3e66
16813d0
84cc483
f84efa5
f62984c
0bcc534
4bda395
200877a
81020be
cc7d08e
fc980d5
7c09b39
794b7f6
17f3834
c67d1da
f0bed9d
ad4693e
b6343ea
8a6e845
3553784
0ce9fb5
9a9ac86
a4145e2
16c9d11
70d97d8
7524467
3ab7c49
54042e9
5d2b70b
c56378b
0b295f6
1becc95
1554d51
bd89012
9fb3fe4
f9e34b5
b2a9f40
33df5c1
451e59e
fbc8d02
027c547
6ae98be
e9e307f
58fed54
3f80f62
a3d366e
426ec54
26923a4
969e1eb
1524b94
5c1e13d
ee95dd3
4155ab5
e261111
b63a809
662c904
06cd260
6390c24
bc778a7
11b23b4
5fe2041
3385d32
0401e21
8ec4a81
64437f9
99bd0ed
1defc76
f518c44
e798332
fc923f7
bfe264e
5a266b0
1fe6481
9d15f81
2bc9c4d
6f08a1b
d1b0f84
15e0177
183dc0a
c1b0af7
7dfec84
8564589
e2b7aa5
75c80f2
60626f6
0a00cf0
c21d1f6
3e53b5a
ca42c64
c136552
77f2f7d
ab4f0f7
2a92bbf
737ae3d
e78cafb
60fff09
eb46f89
6aa73a5
22276c8
1fc4e52
d69ffb3
7670f82
cdd1f9e
42d0e10
8f66198
a5f9469
af6d2c1
3e82f85
6352ce6
8ca7b3d
c321fff
c21559b
b7dd01c
1378454
f1e2494
652a2c3
b85e66d
f725349
0e985ff
cad996c
0890018
972e8d5
49c7c9f
5772f48
7bccff4
5933648
833f128
bf95091
0f0c37f
0a0d037
4a39a87
c859aac
e89193f
588c173
ca62a94
133f7ce
6d4e53c
7212d24
0e164b5
3d29403
297017f
b7e4565
e30fab5
140034d
5c02632
2507b06
0c419d1
c2e15e1
e8ff3f6
a1b79bd
42759e5
fc76faf
9be46ee
1e566c2
746f769
0e323b2
8e776ee
541fdfc
5578108
3d69c3b
1bb6f56
65563a9
432649e
ab0f7c6
fbc46f9
708059a
77e56d9
9a0a3d1
4ff5ba1
14d7d71
9a29326
58e7ef5
c2a946d
d7ba031
792338b
1b9adf7
6263108
2b704f1
f161fb2
f8f9a0e
0b4c275
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,8 +16,11 @@ on: | |
| branches: | ||
| - main | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| types: | ||
| - opened | ||
| - reopened | ||
| - ready_for_review | ||
| - synchronize | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.head_ref || github.ref }} | ||
|
|
@@ -27,23 +30,44 @@ jobs: | |
| ci: | ||
| name: 'CI' | ||
| uses: verkstedt/actions/.github/workflows/ci.yaml@v1 | ||
| secrets: inherit | ||
| with: | ||
| working-directory: . | ||
|
|
||
| lint-deps: | ||
| name: 'Lint dependencies' | ||
| lint-pkg: | ||
| name: 'Lint package.json' | ||
| runs-on: ubuntu-latest | ||
| needs: | ||
| - ci | ||
| steps: | ||
| - name: Setup | ||
| uses: verkstedt/actions/setup@v1 | ||
| with: | ||
| working-directory: . | ||
| - name: Lint package.json | ||
| working-directory: . | ||
| run: npm run lint:pkg | ||
|
|
||
| lint-node: | ||
| name: 'Lint Node.js versions' | ||
| runs-on: ubuntu-latest | ||
| needs: | ||
| - ci | ||
| steps: | ||
| - name: Setup | ||
| uses: verkstedt/actions/setup@v1 | ||
| with: | ||
| working-directory: . | ||
| - name: Lint Node.js versions | ||
| working-directory: . | ||
| run: npm run lint:node | ||
|
|
||
| notify-main-branch-failure: | ||
| name: Notify about failure on main branch | ||
| needs: | ||
| - ci | ||
| - lint-deps | ||
| if: failure() && github.ref == 'refs/heads/main' | ||
| - lint-pkg | ||
| - lint-node | ||
| if: failure() && github.head_ref == 'main' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hm. It’s part of a template that’s used in quite a few repos already. I’ll do some more testing on it tomorrow. But it seems what we want here is: if: failure() && github.ref_name === 'main'No need to check for |
||
| uses: verkstedt/actions/.github/workflows/notify-main-branch-failure.yaml@v1 | ||
| secrets: inherit | ||
|
marek-saji marked this conversation as resolved.
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| name: 'Create Release' | ||
|
|
||
| # Push a commit bumping up the version | ||
| # | ||
| # Requires some secrets and/or vars | ||
| # and setting up a GitHub app in an organisation. | ||
| # See https://github.com/verkstedt/actions#create-release | ||
| # | ||
| # This file has been created from | ||
| # https://github.com/verkstedt/.github/blob/main/workflow-templates/create-release.yaml | ||
| # | ||
| # IF YOU MODIFY IT IN ANY WAY, DESCRIBE IT IN THE COMMENT HERE | ||
| # to make updating in the future easier. | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| release-type: | ||
| description: 'Type of release (major, minor, patch, or prerelease)' | ||
| type: string | ||
| default: 'patch' | ||
| dry-run: | ||
| description: 'Dry–run' | ||
| type: boolean | ||
| default: false | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }} | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| release: | ||
| name: 'Create release' | ||
| uses: verkstedt/actions/.github/workflows/create-release.yaml@v1 | ||
| secrets: | ||
| GITHUB_APP_PRIVATE_KEY: ${{ secrets.CREATE_RELEASE_APP_PRIVATE_KEY }} | ||
| SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }} | ||
| GH_NPM_REGISTRY_PERSONAL_ACCESS_TOKEN: ${{ secrets.GH_NPM_REGISTRY_PERSONAL_ACCESS_TOKEN }} | ||
| with: | ||
| release-type: '${{ github.event.inputs.release-type }}' | ||
| dry-run: ${{ github.event.inputs.dry-run == 'true' }} | ||
| github-app-id: ${{ vars.CREATE_RELEASE_APP_ID }} | ||
| slack-channel-id: ${{ vars.SLACK_CHANNEL_ID }} | ||
|
|
||
| notify-failure: | ||
| name: 'Notify about failure' | ||
| needs: | ||
| - release | ||
| if: failure() && inputs.dry-run != true | ||
| uses: verkstedt/actions/.github/workflows/notify-main-branch-failure.yaml@v1 | ||
| secrets: inherit |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: 'Jira integration' | ||
|
|
||
| # Move Jira issues when PRs are created, published or merged. | ||
| # | ||
| # Requires some secrets and/or vars! | ||
| # See https://github.com/verkstedt/actions#jira | ||
| # | ||
| # This file has been created from | ||
| # https://github.com/verkstedt/.github/blob/main/workflow-templates/jira.yaml | ||
| # | ||
| # IF YOU MODIFY IT IN ANY WAY, DESCRIBE IT IN THE COMMENT HERE | ||
| # to make updating in the future easier. | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| types: | ||
| - opened | ||
| - edited | ||
| - closed | ||
| - reopened | ||
| - ready_for_review | ||
| - converted_to_draft | ||
|
|
||
| jobs: | ||
| jira: | ||
| name: 'Move jira issues' | ||
| uses: verkstedt/actions/.github/workflows/jira.yaml@v1 | ||
| secrets: inherit |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| name: 'Ref Comment in Commit' | ||
|
|
||
| # Make it possible to reference a GH comment in a commit message. | ||
| # | ||
| # This file has been created from | ||
| # https://github.com/verkstedt/.github/blob/main/workflow-templates/ref-comment-in-commit.yaml | ||
| # | ||
| # IF YOU MODIFY IT IN ANY WAY, DESCRIBE IT IN THE COMMENT HERE | ||
| # to make updating in the future easier. | ||
|
|
||
| on: | ||
| push: | ||
|
|
||
| jobs: | ||
| ref-comments: | ||
| name: 'Ref Comment in Commit' | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: 'Ref Comment in Commit' | ||
| uses: 'verkstedt/actions/ref-comment-in-commit@v1' | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| /node_modules | ||
| .vscode | ||
| .DS_Store | ||
| # dependencies | ||
| node_modules | ||
|
|
||
| # build artifacts | ||
| /esm |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| v18.19.1 | ||
| 24.12.0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Generated | ||
| /CHANGELOG.md | ||
|
|
||
| # Tests | ||
| /test/ |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Make sure dependabot PRs get reviewers assigned | ||
| package-lock.json @marek-saji |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,13 @@ | ||
| MIT License | ||
|
|
||
| Copyright (c) 2015-2017 Moviepilot, Inc. | ||
| Copyright (c) 2017 verkstedt GmbH | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| Copyright (C) 2025 by verkstedt GmbH <info@verkstedt.com> | ||
|
|
||
| Permission to use, copy, modify, and/or distribute this software for any | ||
| purpose with or without fee is hereby granted, provided that the above | ||
| copyright notice and this permission notice appear in all copies. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES | ||
| WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF | ||
| MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR | ||
| ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES | ||
| WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN | ||
| ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF | ||
| OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. |
Uh oh!
There was an error while loading. Please reload this page.