Skip to content

Fix linting issues from future config#40

Merged
marek-saji merged 2 commits intov1from
chore/future-linting
Jan 26, 2026
Merged

Fix linting issues from future config#40
marek-saji merged 2 commits intov1from
chore/future-linting

Conversation

@marek-saji
Copy link
Contributor

Why?

Fixes issues found while testing the upcoming new version of verkstedt linting config.

Refs VIP-19.

@marek-saji marek-saji self-assigned this Jan 26, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Documentation

    • Updated image markup syntax in documentation files for consistency.
  • Chores

    • Optimized cloud deployment workflow container flag handling.
    • Added ESLint configuration for import resolution.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

The PR updates GitHub Actions workflow configuration to improve container flag handling via shell argument reassembly, converts Markdown image syntax to HTML in documentation files, and adds an ESLint directive to suppress import warnings for GitHub Actions dependencies.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/deploy-cloudrun.yaml
Modified container flag handling: replaced per-flag construction pattern with shell argument reassembly using set -- for conditional flag passing to gcloud deploy commands.
Documentation
DESIGN.md, README.md
Converted Markdown image syntax (![](path)) to HTML <img> tags with empty alt attributes across screenshot references.
ESLint Configuration
ref-comment-in-commit/index.mjs
Added top-level ESLint directive comment to suppress unresolved import warnings for @actions/ packages without altering runtime logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • feat: add cloudrun deploy job #29: Modifies the same .github/workflows/deploy-cloudrun.yaml file and addresses container/flag handling logic for Cloud Run deployments.

Suggested reviewers

  • erolci
  • karelchudej

Poem

🐰 A workflow refined with shell's clever dance,
Images dressed in HTML's fancy pants,
Linting whispers hush unresolved cries—
Small tweaks that make the pipeline wise! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning VIP-19 focuses on creating a new ESLint config package and restructuring the linting system, but this PR only fixes linting issues in existing code files without implementing the core objectives. This PR addresses linting fixes but does not implement VIP-19's main objectives: creating @verkstedt/lint package, adopting new ESLint format, or reorganizing configs. Consider clarifying whether this is a prerequisite fix or if VIP-19 implementation should follow.
Out of Scope Changes check ❓ Inconclusive The changes (GitHub Actions workflow updates, Markdown syntax changes, and ESLint directive) are reasonable linting fixes but are not directly aligned with VIP-19's core refactoring objectives. Review whether the specific changes (e.g., image syntax conversion, ESLint directive addition) are necessary for the future linting config or if they should be deferred until VIP-19 implementation.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix linting issues from future config' clearly summarizes the main change: addressing linting issues that appeared when testing a new linting configuration.
Description check ✅ Passed The description explains that the PR fixes issues found while testing an upcoming new linting config and references VIP-19, which is directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@marek-saji marek-saji merged commit 16ff888 into v1 Jan 26, 2026
2 checks passed
@marek-saji marek-saji deleted the chore/future-linting branch January 26, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants