Skip to content

feat: Remove old reusable workflows#33

Merged
marek-saji merged 1 commit intov1from
feat/rm-old-reusable-workflows
Dec 1, 2025
Merged

feat: Remove old reusable workflows#33
marek-saji merged 1 commit intov1from
feat/rm-old-reusable-workflows

Conversation

@marek-saji
Copy link
Contributor

Why?

Deprecated by #25 and #26

Closes https://verkstedt.atlassian.net/browse/VIP-96

Is this safe?

There don’t seem to be any active usage of these:

https://github.com/search?q=%22verkstedt%2Factions%2F.github%2Fworkflows%2Freusable-%22&ref=opensearch&type=code

Important

Remember this is a public repo, DO NOT discuss non–public projects here.

@marek-saji marek-saji self-assigned this Nov 25, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed GitHub Actions workflow for automated release creation, including version determination and release notes generation.
    • Removed GitHub Actions workflow for Docker image tagging and distribution to container registries.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

This PR removes two GitHub Actions reusable workflows: one for creating releases with version determination logic, and another for tagging and pushing Docker images to multiple container registries (GHCR and GAR).

Changes

Cohort / File(s) Summary
Removed GitHub Actions workflows
.github/workflows/reusable-release.yml, .github/workflows/reusable-tag-docker-release-images.yml
Deleted two reusable workflow files: release workflow (version determination, release notes generation, draft release creation) and Docker tagging/push workflow (semantic versioning, multi-registry image distribution)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify no other workflows or documentation reference these deleted reusable workflows
  • Confirm any replacement workflows or migration paths are in place
  • Ensure the removal aligns with the broader workflow restructuring effort (VIP-96)

Possibly related PRs

  • chore: Update third party actions #24: Modifies the same workflow files (reusable-release.yml and reusable-tag-docker-release-images.yml) but updates action versions, indicating these workflows were being maintained before this deletion.

Suggested reviewers

  • erolci

Poem

🐰 Old workflows fade like morning dew,
Reusable tasks we bid adieu,
Release and docker scripts now gone,
Cleaner paths to carry on! 🧹✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: Remove old reusable workflows' directly and accurately summarizes the main change—removal of deprecated reusable GitHub Actions workflows.
Description check ✅ Passed The description provides clear context: reason for removal (deprecation by PRs #25 and #26), issue linkage (VIP-96), safety verification through repository search, and appropriate caution about public repo status.
Linked Issues check ✅ Passed The PR addresses VIP-96 by removing deprecated reusable workflows as specified, with verification that no active usage exists and deprecation is confirmed by prior PRs.
Out of Scope Changes check ✅ Passed All changes are in-scope: two deprecated reusable workflow files are removed entirely, with no unrelated modifications to other files or code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/rm-old-reusable-workflows

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 664319a and 326dded.

📒 Files selected for processing (2)
  • .github/workflows/reusable-release.yml (0 hunks)
  • .github/workflows/reusable-tag-docker-release-images.yml (0 hunks)
💤 Files with no reviewable changes (2)
  • .github/workflows/reusable-release.yml
  • .github/workflows/reusable-tag-docker-release-images.yml

Comment @coderabbitai help to get the list of available commands and usage tips.

@marek-saji marek-saji merged commit 1911e01 into v1 Dec 1, 2025
2 checks passed
@marek-saji marek-saji deleted the feat/rm-old-reusable-workflows branch December 1, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants