Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

build: use current package manager #147

Closed
wants to merge 2 commits into from
Closed

build: use current package manager #147

wants to merge 2 commits into from

Conversation

DanielRuf
Copy link
Contributor

Type:
build

Description:

This PR uses the environment setting to use the current package manager for the commands.

@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   84.12%   84.12%           
=======================================
  Files          92       92           
  Lines         926      926           
  Branches      166      166           
=======================================
  Hits          779      779           
  Misses        128      128           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584f4c1...0ecd5c2. Read the comment docs.

@DanielRuf
Copy link
Contributor Author

We will have to test all commands on all three / two platforms: Unix / Linux + macOS and Windows.

@sergiohgz
Copy link
Member

sergiohgz commented Oct 2, 2019

Let me try this in monorepo. There we have CI in Windows, Linux and MacOS, so it could be easier to test on all main systems

@sergiohgz
Copy link
Member

I tried the use of $npm_execpath on lint stage in monorepo and you can see that it won't work on Windows. Check results for Node 12 and in Node 10, the variable is not found.

@DanielRuf
Copy link
Contributor Author

@sergiohgz hm, can you try cross-env-shell instead?

See kentcdodds/cross-env#91

@DanielRuf
Copy link
Contributor Author

I will squash them then when this resolves it.

@sergiohgz
Copy link
Member

https://github.com/verdaccio/monorepo/runs/244666867

At the moment of writing this comment, it has been stuck for 10 minutes in the step, it seems to not work 😞

@sergiohgz
Copy link
Member

If I understand this section of cross-env docs, cmd doesn't accept command substitution

@DanielRuf
Copy link
Contributor Author

If I understand this section of cross-env docs, cmd doesn't accept command substitution

Hm, weird. I thought this worked at home in another project.
But cross-env-shell should theoretically be able to do this.

I have to test this on my own Winbdows machine when I am at home. But I use Git Bash there. I might have to check if my Windows cmd works there.

@sergiohgz
Copy link
Member

Basically, it suggest to use Powershell to fix the problem. Should we enforce users to use a specific terminal? I don't think so.
In my case, I use VMs or WSL on Windows, so I cannot test it directly

@DanielRuf
Copy link
Contributor Author

Right. I'm closing this PR then. I thought it works as we use it in another project too.

@DanielRuf DanielRuf closed this Oct 2, 2019
@juanpicado
Copy link
Member

Having fun without me 🤓 .... bad boys ...

@sergiohgz
Copy link
Member

@juanpicado hahaha you know 😜

@DanielRuf DanielRuf deleted the build/use-current-package-manager branch October 25, 2019 10:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants