-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: documentation for type-check in with-shell-commands example #9953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Asupkay is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
anthonyshew
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
joshnuss
pushed a commit
to joshnuss/turborepo
that referenced
this pull request
Feb 15, 2025
…cel#9953) ### Description If you run `turbo typecheck` which the documentation currently suggests you get an error that it could not find `typecheck` in project. <img width="649" alt="Screenshot 2025-02-13 at 12 57 27 AM" src="https://github.com/user-attachments/assets/7c7fcc3d-d68a-4c43-b03d-a9d7a8922ec9" /> This pull request updates the documentation to `type-check` which aligns with what is in the packages and apps. <img width="699" alt="Screenshot 2025-02-13 at 12 57 46 AM" src="https://github.com/user-attachments/assets/2e25b7c2-db5e-4418-8646-a5201f2fc148" /> ### Testing Instructions Go into `examples/with-shell-commands` and run `turbo type-check`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: examples
Improvements or additions to examples
needs: triage
New issues get this label. Remove it after triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you run
turbo typecheck
which the documentation currently suggests you get an error that it could not findtypecheck
in project.This pull request updates the documentation to
type-check
which aligns with what is in the packages and apps.Testing Instructions
Go into
examples/with-shell-commands
and runturbo type-check