Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: documentation for type-check in with-shell-commands example #9953

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Asupkay
Copy link
Contributor

@Asupkay Asupkay commented Feb 13, 2025

Description

If you run turbo typecheck which the documentation currently suggests you get an error that it could not find typecheck in project.

Screenshot 2025-02-13 at 12 57 27 AM

This pull request updates the documentation to type-check which aligns with what is in the packages and apps.

Screenshot 2025-02-13 at 12 57 46 AM

Testing Instructions

Go into examples/with-shell-commands and run turbo type-check

@Asupkay Asupkay requested a review from a team as a code owner February 13, 2025 06:01
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage labels Feb 13, 2025
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 3:22am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 3:22am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 3:22am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 3:22am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 3:22am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 3:22am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 3:22am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 3:22am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 3:22am

Copy link

vercel bot commented Feb 13, 2025

@Asupkay is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@Asupkay Asupkay changed the title Fix: Documentation for type-check in with-shell-commands example fix: Documentation for type-check in with-shell-commands example Feb 13, 2025
@Asupkay Asupkay changed the title fix: Documentation for type-check in with-shell-commands example fix: documentation for type-check in with-shell-commands example Feb 13, 2025
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthonyshew anthonyshew enabled auto-merge (squash) February 14, 2025 03:22
@anthonyshew anthonyshew merged commit 9758357 into vercel:main Feb 14, 2025
31 of 33 checks passed
joshnuss pushed a commit to joshnuss/turborepo that referenced this pull request Feb 15, 2025
…cel#9953)

### Description

If you run `turbo typecheck` which the documentation currently suggests
you get an error that it could not find `typecheck` in project.

<img width="649" alt="Screenshot 2025-02-13 at 12 57 27 AM"
src="https://github.com/user-attachments/assets/7c7fcc3d-d68a-4c43-b03d-a9d7a8922ec9"
/>

This pull request updates the documentation to `type-check` which aligns
with what is in the packages and apps.

<img width="699" alt="Screenshot 2025-02-13 at 12 57 46 AM"
src="https://github.com/user-attachments/assets/2e25b7c2-db5e-4418-8646-a5201f2fc148"
/>

### Testing Instructions

Go into `examples/with-shell-commands` and run `turbo type-check`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants