test: add tests for authentication tokens and SSO #9937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anthonyshew
requested review from
chris-olszewski
and removed request for
dimitropoulos
anthonyshew
changed the title
chris-olszewski
approved these changes
Feb 11, 2025
| ) -> turborepo_api_client::Result<turborepo_vercel_api::token::ResponseTokenMetadata> | ||
| { | ||
| if token.is_empty() { | ||
| return Err(MockApiError::EmptyToken.into()); |
There was a problem hiding this comment.
Was there really not a test that asserted this mocked out error? :lolsob:
| #[tokio::test] | ||
| async fn test_sso_login_force_new_token() { | ||
| let port = port_scanner::request_open_port().unwrap(); | ||
| let api_server = tokio::spawn(start_test_server(port)); |
There was a problem hiding this comment.
We don't need to start an HTTP server since we're mocking out the HTTP requests via the MockApiClient
Suggested change
| let api_server = tokio::spawn(start_test_server(port)); |
joshnuss
pushed a commit
to joshnuss/turborepo
that referenced
this pull request
Feb 15, 2025
### Description Adding some tests before I do some bug hunting/fixing. ### Testing Instructions CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding some tests before I do some bug hunting/fixing.
Testing Instructions
CI