chore(release): remove goreleaser #9909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tknickman
approved these changes
Feb 6, 2025
tknickman
added a commit
that referenced
this pull request
Feb 7, 2025
Reverts #9909 Issue with marking bin as executable on publish: ``` <ref *1> Error: spawnSync /Users/knickman/.npm/_npx/41b87e1488d166d0/node_modules/turbo-darwin-arm64/bin/turbo EACCES at Object.spawnSync (node:internal/child_process:1117:20) at spawnSync (node:child_process:876:24) at Object.execFileSync (node:child_process:919:15) at Object.<anonymous> (/Users/knickman/.npm/_npx/41b87e1488d166d0/node_modules/turbo/bin/turbo:266:17) at Module._compile (node:internal/modules/cjs/loader:1364:14) at Module._extensions..js (node:internal/modules/cjs/loader:1422:10) at Module.load (node:internal/modules/cjs/loader:1203:32) at Module._load (node:internal/modules/cjs/loader:1019:12) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12) at node:internal/main/run_main_module:28:49 { errno: -13, code: 'EACCES', ```
chris-olszewski
added a commit
that referenced
this pull request
Feb 10, 2025
### Description Third try is the charm. See #9905 and #9909 for details. Additional changes: - Make sure `turbo` binaries are marked as executable. Since they get downloaded via `@actions/download-artifact` which strips permissions: [docs](https://github.com/actions/download-artifact?tab=readme-ov-file#permission-loss) - Correctly set `os: ["win32"]` for the windows package for `turbo-windows-${arch}` ### Testing Instructions Changes from previous PRs: added an e2e test to make sure that the tarball is installable and the included executable is just that.
chris-olszewski
added a commit
that referenced
this pull request
Feb 10, 2025
### Description Third try is the charm. See #9905 and #9909 for details. Additional changes: - Make sure `turbo` binaries are marked as executable. Since they get downloaded via `@actions/download-artifact` which strips permissions: [docs](https://github.com/actions/download-artifact?tab=readme-ov-file#permission-loss) - Correctly set `os: ["win32"]` for the windows package for `turbo-windows-${arch}` ### Testing Instructions Changes from previous PRs: added an e2e test to make sure that the tarball is installable and the included executable is just that.
joshnuss
pushed a commit
to joshnuss/turborepo
that referenced
this pull request
Feb 15, 2025
### Description Third try is the charm. See vercel#9905 and vercel#9909 for details. Additional changes: - Make sure `turbo` binaries are marked as executable. Since they get downloaded via `@actions/download-artifact` which strips permissions: [docs](https://github.com/actions/download-artifact?tab=readme-ov-file#permission-loss) - Correctly set `os: ["win32"]` for the windows package for `turbo-windows-${arch}` ### Testing Instructions Changes from previous PRs: added an e2e test to make sure that the tarball is installable and the included executable is just that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finally remove
goreleaserafter Go left the codebase a year ago. This does almost exactly what we were doing withgoreleaserexcept we now base the native releases off ofversion.txtcontents like every other package and not Git tags.I highly recommend reading each commit especially the first one as I mark up the
goreleaserflow we were using explaining what exactly it did.Updates from #9905
Include
LICENSEin the native package distributionsCreate a tarball containing a directory that contains our package. Closer reading of the npm docs make it clear this is what it expects:
We had
wrap_in_directory: truein our goreleaser workflow which did this for us.Testing Instructions
Latest dry run
The dry run got up to the publishing step! All of the
tar.gzfiles look correct: logsRunning locally, the contents of
tar.gzlooks to be correct:What hasn't been tested is the actual
npm publishcall, but I am fairly certain that will work as it's a very similar shell command to the one used ingoreleaser