Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: many examples fixes #9898

Merged
merged 17 commits into from
Feb 5, 2025
Merged

ci: many examples fixes #9898

merged 17 commits into from
Feb 5, 2025

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Feb 4, 2025

Description

After working well for a brief moment in time, the examples are inexplicably quite broken somehow. This PR has a good number of fixes to try to unstuck them once again:

  • I had to install ESLint into each package to fix pnpm usage. Unfortunately, this isn't in service of making the examples better. Rather, we were getting the ESLint version running from the outer repository when there wasn't an ESLint specified in the repo.
  • This PR improves logging with a tee for CI debugging. We previously had poor visibility in CI and were getting vastly different behavior between CI and local (still are 😞). The tee should help a little.
  • We're using a real temp_dir now. This was done to try to fix the aforementioned ESLint issue, but it's probably what we should have been doing anyway before.
  • We were accidentally running the kitchen-sink tests twice and never running basic due to a copy-pasting error. My bad.

Testing Instructions

CI

@anthonyshew anthonyshew requested a review from a team as a code owner February 4, 2025 14:51
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:04am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:04am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:04am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:04am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:04am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:04am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:04am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:04am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:04am

turborepo-tests/helpers/setup_example_test.sh Outdated Show resolved Hide resolved
turborepo-tests/helpers/setup_example_test.sh Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci area: examples Improvements or additions to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants