Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(examples): update version in examples on release #9823

Merged
merged 11 commits into from
Jan 27, 2025
Merged

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Jan 27, 2025

Description

Updates the turbo version in examples whenever we make a release. This ignores canaries so we don't ship those to unexpecting users.

I'm not sure that this is a sustainable solution as the community continues to add more examples since the many pnpm update calls might take awhile. However, I feel like this isn't a performance-critical path for us, so going to go with it until someone tells me not to/thinks of a more clever way. Note that whatever we go with needs to 1) bump the version in package.json and 2) update the lockfile.

@anthonyshew anthonyshew requested a review from a team as a code owner January 27, 2025 20:37
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:35pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:35pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:35pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:35pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:35pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:35pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:35pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:35pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:35pm

Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.github/workflows/update-examples-on-release.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants