feat(@turbo/codemod): add support for custom NPM registries #9803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
needs: triage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Meligy
changed the title
Meligy
force-pushed
the
feat/custom-npm-repos
branch
from
851efda to
be0f731
Compare
anthonyshew
reviewed
Jan 27, 2025
| @@ -12,9 +12,12 @@ interface PackageDetailsResponse { | |||
| } | |||
|
|
|||
| async function getPackageDetails({ packageName }: { packageName: string }) { | |||
| const registry = | |||
| process.env.npm_config_registry?.replace(/\/$/, "") || DEFAULT_REGISTRY; | |||
There was a problem hiding this comment.
Can you explain the reason for this .replace here? grep.app doesn't show me any prior art for this, though without the regex does. I'm figuring there's something I'm missing, just can't tell what it is.
There was a problem hiding this comment.
The reason is to convert https://registry.npmjs.org/ to https://registry.npmjs.org
Happy to remove it though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4152
Description
NPM (and alternative tools like PNPM) pass the registry as an environment variable
npm_config_registry.This allows the
codemodpackage to use it when present (which is often the case).Testing Instructions
turbo-codemodturbo run builddist/cli.js migrate --to=latest --force(maybe play with othertovalues also)