Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linting): add name property to ESLint recommended flat config #9765

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

jeremy-code
Copy link
Contributor

@jeremy-code jeremy-code commented Jan 23, 2025

Description

  • eslint-plugin-turbo["flat/recommended"] currently has no name property and is anonymous.
  • Per ESLint guidance, a name property should be added to configuration files for debugging.

image

Testing Instructions

pnpm run test --filter=eslint-plugin-turbo

PASS  __tests__/cwdFlat.test.ts (15.115 s)
PASS  __tests__/cwd.test.ts (15.289 s)

Test Suites: 10 passed, 10 total
Tests:       102 passed, 102 total
Snapshots:   0 total
Time:        15.623 s

@jeremy-code jeremy-code requested a review from a team as a code owner January 23, 2025 03:31
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo labels Jan 23, 2025
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:10pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:10pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:10pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:10pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:10pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:10pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:10pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:10pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:10pm

Copy link

vercel bot commented Jan 23, 2025

@jeremy-code is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Jan 23, 2025

Allow CI Workflow Run

  • approve CI run for commit: 17b466d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! Thanks!

@anthonyshew
Copy link
Contributor

@jeremy-code, it looks like this change creates this type error. Do you know why that is?

@jeremy-code
Copy link
Contributor Author

My bad, I only ran test and not check-types; looks like I had to bump some dependencies for the correct types (@types/eslint 8.44.2 -> 8.56.10 and @types/estree 1.0.0 -> 1.0.1). Think this should work now.

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants