fix: order tasks in order of interest, namely failed, successful, then cached #9353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
needs: triage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
arlyon
force-pushed
the
arlyon/task-ordering
branch
from
61bbde3
to
27b81b3
Compare
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
chris-olszewski
approved these changes
Oct 31, 2024
| .iter() | ||
| // note we can't use the default Ord impl because | ||
| // we want failed tasks first | ||
| .sorted_by_key(|task| match task.result() { |
There was a problem hiding this comment.
Non blocking TODO for myself (or anyone else), but we should try to insert tasks as they finish in this order instead of sorting it on every render.
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when running tasks using the new UI, turbo inserts passed / failed tasks below cached tasks (in order of completion) meaning the stuff users probably want to see (failed things) end up at the bottom of the list or off screen. This change attempts to improve that by inserting those items in front of the list of cached tasks. That way cached tasks (likely the least interesting) end up last and preceded by successful tasks and then failed tasks. This assumes that users will more interested in failed tasks than successful ones but I am also open to ordering just the failed / successful task in order of completion instead.
In practice this means if running turbo in a large project with
--continuewhere the majority of tasks are and will remain cached between runs, then the things that are 'interesting' will usually be close to the user's cursor.It also 'fixes' the case where viewing a task that is completed jumps past the cached tasks and you have to traverse back through them all to get to the top again.