Skip to content

Use ast-grep GitHub action and pin versions#8275

Closed
wbinnssmith wants to merge 7 commits intomainfrom
wbinnssmith/ast-grep-action
Closed

Use ast-grep GitHub action and pin versions#8275
wbinnssmith wants to merge 7 commits intomainfrom
wbinnssmith/ast-grep-action

Conversation

@wbinnssmith
Copy link
Copy Markdown
Member

This uses the official ast-grep GitHub Action [0] instead of installing it from npm in the clippy job.

Thanks for the suggestion from @HerringtonDarkholme!

[0] https://github.com/ast-grep/action
[1] #5637 (comment)

@wbinnssmith wbinnssmith requested review from a team as code owners June 3, 2024 16:40
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 6:00pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm
rust-docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 6:00pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 3, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 3, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Turbopack Rust benchmark tests (linux)
  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Copy Markdown
Contributor

✅ This change can build next-swc

This uses the official ast-grep GitHub Action [0] instead of installing it from npm in the clippy job.

Thanks for the suggestion from @HerringtonDarkholme!

[0] https://github.com/ast-grep/action
[1] #5637 (comment)
@HerringtonDarkholme
Copy link
Copy Markdown

Hi! I have also published v1.6 to include the new path argument in action. Let me know if it works for you.

@wbinnssmith wbinnssmith marked this pull request as draft June 11, 2024 22:56
@wbinnssmith
Copy link
Copy Markdown
Member Author

wbinnssmith commented Jun 12, 2024

Hi! I have also published v1.6 to include the new path argument in action. Let me know if it works for you.

@HerringtonDarkholme It looks like the action has stale dist and needs an npm run build 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci Internal CI for vercel/turborepo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants