Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples tests revamp. #7098

Merged
merged 59 commits into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from 52 commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
f671b7a
First pass at tests.
anthonyshew Jan 25, 2024
ded607c
Fix bugs in examples! Nice!
anthonyshew Jan 25, 2024
5a1dc88
Line up GitHub Action.
anthonyshew Jan 25, 2024
ca18e14
Move files and re-establish workspaces.
anthonyshew Jan 25, 2024
fae4266
Fix up paths and let GHA use Remote Cache.
anthonyshew Jan 25, 2024
da8ec84
Dump logs when we fail.
anthonyshew Jan 25, 2024
7e8d326
Fix bug in with-rollup.
anthonyshew Jan 25, 2024
8c11179
Remove dead helper.
anthonyshew Jan 25, 2024
0135a1d
Purposeful error.
anthonyshew Jan 25, 2024
c32b463
Fix purposeful mistake and add README.
anthonyshew Jan 25, 2024
b1ead9a
Merge branch 'main' into examples-tests-revamp
anthonyshew Jan 25, 2024
7f59b02
Merge branch 'main' into examples-tests-revamp
anthonyshew Jan 25, 2024
6322446
Update turborepo-tests/examples/test_example.sh
anthonyshew Jan 25, 2024
cf604e0
Remove turbo that I accidentally installed.
anthonyshew Jan 25, 2024
ac342ea
Correct task inputs.
anthonyshew Jan 25, 2024
736924b
One more.
anthonyshew Jan 25, 2024
cdc3694
Fix lockfile.
anthonyshew Jan 25, 2024
f83aece
Correct packages.
anthonyshew Jan 25, 2024
1061eee
Remove extra turbo.json.
anthonyshew Jan 25, 2024
8b58adc
Move test_example.sh.
anthonyshew Jan 25, 2024
1884b02
Clean up pnpm-workspace.yaml.
anthonyshew Jan 25, 2024
cd59c01
Have to enumerate them, I guess.
anthonyshew Jan 25, 2024
301a7a1
Merge branch 'main' into examples-tests-revamp
anthonyshew Jan 25, 2024
127cb4c
Go back to original workspace yml.
anthonyshew Jan 25, 2024
f881535
Merge branch 'examples-tests-revamp' of https://github.com/vercel/tur…
anthonyshew Jan 25, 2024
5627b94
Fix lockfile.
anthonyshew Jan 25, 2024
892b4bf
Repath.
anthonyshew Jan 25, 2024
57a8057
Merge branch 'main' into examples-tests-revamp
anthonyshew Jan 26, 2024
c809d45
Rename script.
anthonyshew Jan 26, 2024
287aa4b
Isolate git.
anthonyshew Jan 26, 2024
d14e09e
Better test isolation.
anthonyshew Jan 26, 2024
f19606b
Change command back.
anthonyshew Jan 26, 2024
3718db0
More debug help.
anthonyshew Jan 26, 2024
25269f6
Ensure concurrency in GHA.
anthonyshew Jan 26, 2024
0cc5621
Just need to fix non-monorepo.
anthonyshew Jan 26, 2024
300a271
Okay, it works.
anthonyshew Jan 26, 2024
82dd719
Cargo, wyd.
anthonyshew Jan 26, 2024
557e850
Merge branch 'main' of https://github.com/vercel/turbo into examples-…
anthonyshew Jan 26, 2024
49ce557
Fix ups from main.
anthonyshew Jan 26, 2024
a34ef26
Rename file.
anthonyshew Jan 26, 2024
ae7941d
Back off cargo.
anthonyshew Jan 26, 2024
8ba162c
cargooooo
anthonyshew Jan 26, 2024
32f484c
Rename.
anthonyshew Jan 26, 2024
7eb7e1e
Update turborepo-tests/README.md
anthonyshew Jan 29, 2024
9442729
Update turborepo-tests/README.md
anthonyshew Jan 29, 2024
992d6e2
Use node_modules.
anthonyshew Jan 29, 2024
920870f
Rename workspaces back to original.
anthonyshew Jan 29, 2024
b04cc9b
Exit if path or package manager not provided.
anthonyshew Jan 29, 2024
686b5ee
Fix GHA for workspace rename.
anthonyshew Jan 29, 2024
cc605d8
Use a temp dir.
anthonyshew Jan 29, 2024
290009a
Seems close?
anthonyshew Jan 29, 2024
4abfb91
Cleanup.
anthonyshew Jan 29, 2024
fc3ca47
Alright.
anthonyshew Jan 29, 2024
f8b657f
Reduce flakes?
anthonyshew Jan 29, 2024
881f5eb
Fix with-rollup.
anthonyshew Jan 29, 2024
9c9d703
No concurrency, unfortunate.
anthonyshew Jan 29, 2024
5b6da1d
Update turborepo-tests/helpers/setup_example_test.sh
anthonyshew Jan 29, 2024
ab34a9a
Update turborepo-tests/README.md
anthonyshew Jan 30, 2024
0a8daa6
Cleanups.
anthonyshew Jan 30, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,8 @@ jobs:

- name: Check examples
shell: bash
run: turbo run test -F "@turborepo-examples-tests/*" --continue --color --remote-only --token=${{ secrets.TURBO_TOKEN }} --team=${{ vars.TURBO_TEAM }} --env-mode=strict --concurrency=1
# Concurrency is so we don't hit npm registry rate limits
run: turbo run test --filter="@turborepo-examples-tests/*" --continue --token=${{ secrets.TURBO_TOKEN }} --team=${{ vars.TURBO_TEAM }} --env-mode=strict --concurrency=5

# Disable corepack again. actions/setup-node's "Post" step runs at the end of
# this job invokes other package managers, and corepack throws an error.
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ cli/internal/ffi/libturborepo_ffi*.a
*.t.orig
.cram_env

# Example tests artifacts
examples-tests-tmp/

# generated by tonic
file_descriptor_set.bin

Expand Down
1 change: 1 addition & 0 deletions examples/non-monorepo/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,4 @@ next-env.d.ts

# turbo
.turbo
/tmp/
24 changes: 19 additions & 5 deletions examples/non-monorepo/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
{
"compilerOptions": {
"target": "es5",
"lib": ["dom", "dom.iterable", "esnext"],
"lib": [
"dom",
"dom.iterable",
"esnext"
],
"allowJs": true,
"skipLibCheck": true,
"strict": true,
Expand All @@ -19,9 +23,19 @@
}
],
"paths": {
"@/*": ["./*"]
}
"@/*": [
"./*"
]
},
"forceConsistentCasingInFileNames": true
},
"include": ["next-env.d.ts", "**/*.ts", "**/*.tsx", ".next/types/**/*.ts"],
"exclude": ["node_modules"]
"include": [
"next-env.d.ts",
"**/*.ts",
"**/*.tsx",
".next/types/**/*.ts"
],
"exclude": [
"node_modules"
]
}
2 changes: 2 additions & 0 deletions examples/with-gatsby/apps/web/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/** @type {import("eslint").Linter.Config} */
module.exports = {
extends: ["@repo/eslint-config/gatsby.js"],
ignorePatterns: ["gatsby-types.d.ts"],
};
8 changes: 1 addition & 7 deletions examples/with-gatsby/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/with-rollup/packages/config-eslint/library.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ module.exports = {
],
overrides: [
{
files: ["*.js?(x)", "*.ts?(x)"],
files: ["*.js?(x)", "*.cjs?(x)", "*.mjs?(x)", "*.ts?(x)"],
},
],
};
4 changes: 2 additions & 2 deletions examples/with-rollup/packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
"type": "module",
"exports": {
"./button": {
"types": "./dist/Button.d.ts",
"types": "./Button.tsx",
"default": "./dist/button.js"
},
"./header": {
"types": "./dist/Header.d.ts",
"types": "./Header.tsx",
"default": "./dist/header.js"
}
},
Expand Down
4 changes: 2 additions & 2 deletions examples/with-rollup/turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"$schema": "https://turborepo.org/schema.json",
"pipeline": {
"build": {
"outputs": ["dist/**", "build/**", ".next/**", "!.next/cache/**"],
"dependsOn": ["^build"]
"dependsOn": ["^build"],
"outputs": ["dist/**", ".next/**", "!.next/cache/**"]
},
"lint": {
"outputs": []
Expand Down
Loading
Loading