feat: basic wasm support for turbopack by ForsakenHarmony · Pull Request #5618 · vercel/turborepo

ForsakenHarmony · 2023-07-26T15:54:15Z

Description

Adds basic support for loading WebAssembly files imported from ECMAScript modules.

I've also added some docs to the async module implementation.

vercel · 2023-07-26T15:54:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-kitchensink-blog	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 2, 2023 4:11pm
examples-native-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 2, 2023 4:11pm
examples-nonmonorepo	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 2, 2023 4:11pm
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 2, 2023 4:11pm

7 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:11pm
examples-cra-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:11pm
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:11pm
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:11pm
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:11pm
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:11pm
examples-vite-web	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:11pm

github-actions · 2023-07-26T15:58:24Z

✅ This change can build next-swc

crates/turbopack-wasm/src/lib.rs

github-actions · 2023-07-26T16:06:23Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

github-actions · 2023-07-26T16:26:28Z

Linux Benchmark for `cc84da6`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5441.45µs ± 23.63µs	5406.66µs ± 22.80µs	-0.64%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5069.62µs ± 16.86µs	5070.82µs ± 18.84µs	+0.02%
bench_startup/Turbopack CSR/1000 modules	993.01ms ± 1.79ms	994.16ms ± 2.43ms	+0.12%

github-actions · 2023-07-26T16:59:52Z

MacOS Benchmark for `cc84da6`

Test	Base	PR	%	Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules	23.31ms ± 1.04ms	28.00ms ± 0.13ms	+20.12%	+9.26%
bench_startup/Turbopack CSR/1000 modules	3882.19ms ± 136.27ms	4543.27ms ± 180.29ms	+17.03%	+0.67%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	29.52ms ± 0.15ms	29.60ms ± 0.73ms	+0.30%
bench_hmr_to_eval/Turbopack CSR/1000 modules	23.31ms ± 1.04ms	28.00ms ± 0.13ms	+20.12%	+9.26%
bench_startup/Turbopack CSR/1000 modules	3882.19ms ± 136.27ms	4543.27ms ± 180.29ms	+17.03%	+0.67%

github-actions · 2023-07-28T17:21:31Z

Linux Benchmark for `4da925b`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5931.88µs ± 48.24µs	5882.74µs ± 26.37µs	-0.83%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5393.83µs ± 17.86µs	5658.79µs ± 229.45µs	+4.91%
bench_startup/Turbopack CSR/1000 modules	1002.44ms ± 1.61ms	1005.74ms ± 3.69ms	+0.33%

github-actions · 2023-07-28T17:45:32Z

MacOS Benchmark for `4da925b`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.41ms ± 0.09ms	26.96ms ± 0.11ms	-1.61%	-0.12%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.41ms ± 0.09ms	26.96ms ± 0.11ms	-1.61%	-0.12%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.55ms ± 0.23ms	27.40ms ± 0.36ms	+3.21%
bench_startup/Turbopack CSR/1000 modules	3212.93ms ± 35.29ms	3419.64ms ± 94.53ms	+6.43%

ForsakenHarmony · 2023-07-28T20:41:49Z

Current dependencies on/for this PR:

main
- PR feat: basic wasm support for turbopack #5618 👈
  - PR feat: wasm text format and import support #5636
    - PR feat: support ?module imports for WebAssembly #5660

This comment was auto-generated by Graphite.

github-actions · 2023-07-28T21:00:29Z

Linux Benchmark for `1476de9`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5398.14µs ± 24.55µs	5406.75µs ± 16.85µs	+0.16%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5091.87µs ± 20.73µs	5076.30µs ± 34.65µs	-0.31%
bench_startup/Turbopack CSR/1000 modules	983.59ms ± 2.05ms	989.13ms ± 4.31ms	+0.56%

crates/turbopack-ecmascript-runtime/js/src/build/runtime.ts

crates/turbopack-ecmascript-runtime/js/src/dev/runtime/base/runtime-base.ts

crates/turbopack-ecmascript-runtime/js/src/dev/runtime/nodejs/runtime-backend-nodejs.ts

crates/turbopack-wasm/src/lib.rs

github-actions · 2023-08-01T17:56:05Z

Linux Benchmark for `9d81569`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	6450.64µs ± 51.91µs	6408.43µs ± 115.67µs	-0.65%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5951.39µs ± 55.40µs	6153.19µs ± 304.58µs	+3.39%
bench_startup/Turbopack CSR/1000 modules	993.66ms ± 3.25ms	993.01ms ± 6.56ms	-0.07%

github-actions · 2023-08-01T18:27:42Z

MacOS Benchmark for `9d81569`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	10.04s ± 2.22s	3949.35ms ± 137.28ms	-60.65%	-24.61%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	28.74ms ± 0.09ms	28.48ms ± 0.30ms	-0.91%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.42ms ± 0.80ms	27.95ms ± 0.31ms	+5.79%
bench_startup/Turbopack CSR/1000 modules	10.04s ± 2.22s	3949.35ms ± 137.28ms	-60.65%	-24.61%

github-actions · 2023-08-01T23:16:33Z

Linux Benchmark for `93819b5`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5393.21µs ± 18.45µs	5413.22µs ± 22.59µs	+0.37%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5056.86µs ± 21.97µs	5347.07µs ± 326.02µs	+5.74%
bench_startup/Turbopack CSR/1000 modules	986.58ms ± 0.77ms	986.71ms ± 1.82ms	+0.01%

github-actions · 2023-08-01T23:40:18Z

MacOS Benchmark for `93819b5`

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.37ms ± 0.07ms	27.83ms ± 0.06ms	+1.69%	+0.69%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	27.37ms ± 0.07ms	27.83ms ± 0.06ms	+1.69%	+0.69%
bench_hmr_to_eval/Turbopack CSR/1000 modules	26.89ms ± 0.12ms	26.87ms ± 0.16ms	-0.07%
bench_startup/Turbopack CSR/1000 modules	3443.07ms ± 66.69ms	3517.58ms ± 180.36ms	+2.16%

arlyon

Exciting, approved on behalf of repo

github-actions · 2023-08-02T16:26:38Z

Linux Benchmark for `5d18f0d`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	5377.89µs ± 33.71µs	5402.01µs ± 21.33µs	+0.45%
bench_hmr_to_eval/Turbopack CSR/1000 modules	5056.08µs ± 16.35µs	5138.14µs ± 79.37µs	+1.62%
bench_startup/Turbopack CSR/1000 modules	998.90ms ± 1.39ms	994.22ms ± 3.06ms	-0.47%

github-actions · 2023-08-02T17:00:53Z

MacOS Benchmark for `5d18f0d`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	24.63s ± 3.45s	8154.58ms ± 2697.90ms	-66.89%	-23.56%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	28.55ms ± 0.47ms	27.44ms ± 0.11ms	-3.89%
bench_hmr_to_eval/Turbopack CSR/1000 modules	25.64ms ± 0.74ms	26.62ms ± 0.11ms	+3.83%
bench_startup/Turbopack CSR/1000 modules	24.63s ± 3.45s	8154.58ms ± 2697.90ms	-66.89%	-23.56%

* vercel/turborepo#5582 * vercel/turborepo#5633 * vercel/turborepo#5637 * vercel/turborepo#5648  * vercel/turborepo#5618 * vercel/turborepo#5624 * vercel/turborepo#5597 * vercel/turborepo#5632 * vercel/turborepo#5636 * vercel/turborepo#5666

ForsakenHarmony requested review from a team as code owners July 26, 2023 15:54

ForsakenHarmony requested review from arlyon and chris-olszewski July 26, 2023 15:54

turbo-orchestrator bot added team: turbopack labels Jul 26, 2023

vercel bot deployed to Preview – turbo-site July 26, 2023 15:54 View deployment

ForsakenHarmony removed request for arlyon and chris-olszewski July 26, 2023 15:55

ForsakenHarmony commented Jul 26, 2023

View reviewed changes

crates/turbopack-wasm/src/lib.rs Show resolved Hide resolved

ForsakenHarmony force-pushed the hrmny/web-316-wasm-loading branch from 282591c to e10d36a Compare July 26, 2023 16:08

vercel bot deployed to Preview – turbo-site July 26, 2023 16:10 View deployment

ForsakenHarmony force-pushed the hrmny/web-316-wasm-loading branch from e10d36a to 03a0952 Compare July 28, 2023 16:59

vercel bot deployed to Preview – turbo-site July 28, 2023 17:01 View deployment

ForsakenHarmony force-pushed the hrmny/web-316-wasm-loading branch from 03a0952 to 1c5e836 Compare July 28, 2023 17:04

vercel bot deployed to Preview – turbo-site July 28, 2023 17:05 View deployment

ForsakenHarmony force-pushed the hrmny/web-316-wasm-loading branch from 1c5e836 to e8e8885 Compare July 28, 2023 20:40

vercel bot deployed to Preview – turbo-site July 28, 2023 20:41 View deployment

ForsakenHarmony mentioned this pull request Jul 28, 2023

feat: wasm text format and import support #5636

Merged

sokra approved these changes Jul 31, 2023

View reviewed changes

jridgewell approved these changes Jul 31, 2023

View reviewed changes

crates/turbopack-wasm/src/lib.rs Show resolved Hide resolved

ForsakenHarmony force-pushed the hrmny/web-316-wasm-loading branch from e8e8885 to 9b69862 Compare August 1, 2023 17:37

vercel bot deployed to Preview – turbo-site August 1, 2023 17:39 View deployment

ForsakenHarmony force-pushed the hrmny/web-316-wasm-loading branch from 9b69862 to 279d4e8 Compare August 1, 2023 22:53

ForsakenHarmony enabled auto-merge (squash) August 1, 2023 22:54

vercel bot deployed to Preview – turbo-site August 1, 2023 22:54 View deployment

arlyon approved these changes Aug 2, 2023

View reviewed changes

ForsakenHarmony added 4 commits August 2, 2023 17:36

feat: basic wasm support for turbopack

34e504d

address review comments

4c1aa8b

remove require.resolve

ef4a1ba

update snapshots

2c15280

turbo-orchestrator bot added the area: ci Internal CI for vercel/turborepo label Aug 2, 2023

ForsakenHarmony force-pushed the hrmny/web-316-wasm-loading branch from 279d4e8 to 2c15280 Compare August 2, 2023 16:10

vercel bot deployed to Preview – turbo-site August 2, 2023 16:11 View deployment

ForsakenHarmony merged commit edacec8 into main Aug 2, 2023

ForsakenHarmony deleted the hrmny/web-316-wasm-loading branch August 2, 2023 16:19

ForsakenHarmony mentioned this pull request Aug 2, 2023

feat: support ?module imports for WebAssembly #5660

Merged

sokra mentioned this pull request Aug 3, 2023

update turbopack vercel/next.js#53545

Merged

ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024

feat: basic wasm support for turbopack (vercel/turborepo#5618)

faca052

ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024

feat: basic wasm support for turbopack (vercel/turborepo#5618)

c1fed7c

ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024

feat: basic wasm support for turbopack (vercel/turborepo#5618)

efdcb1d

Conversation

ForsakenHarmony commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

vercel bot commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 26, 2023

Uh oh!

Uh oh!

github-actions bot commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ CI failed ⚠️

Uh oh!

github-actions bot commented Jul 26, 2023

Linux Benchmark for cc84da6

Uh oh!

github-actions bot commented Jul 26, 2023

MacOS Benchmark for cc84da6

Uh oh!

github-actions bot commented Jul 28, 2023

Linux Benchmark for 4da925b

Uh oh!

github-actions bot commented Jul 28, 2023

MacOS Benchmark for 4da925b

Uh oh!

ForsakenHarmony commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 28, 2023

Linux Benchmark for 1476de9

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 1, 2023

Linux Benchmark for 9d81569

Uh oh!

github-actions bot commented Aug 1, 2023

MacOS Benchmark for 9d81569

Uh oh!

github-actions bot commented Aug 1, 2023

Linux Benchmark for 93819b5

Uh oh!

github-actions bot commented Aug 1, 2023

MacOS Benchmark for 93819b5

Uh oh!

arlyon left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 2, 2023

Linux Benchmark for 5d18f0d

Uh oh!

github-actions bot commented Aug 2, 2023

MacOS Benchmark for 5d18f0d

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ForsakenHarmony commented Jul 26, 2023 •

edited

Loading

vercel bot commented Jul 26, 2023 •

edited

Loading

github-actions bot commented Jul 26, 2023 •

edited

Loading

Linux Benchmark for `cc84da6`

MacOS Benchmark for `cc84da6`

Linux Benchmark for `4da925b`

MacOS Benchmark for `4da925b`

ForsakenHarmony commented Jul 28, 2023 •

edited

Loading

Linux Benchmark for `1476de9`

Linux Benchmark for `9d81569`

MacOS Benchmark for `9d81569`

Linux Benchmark for `93819b5`

MacOS Benchmark for `93819b5`

Linux Benchmark for `5d18f0d`

MacOS Benchmark for `5d18f0d`