Skip to content

refactor: Remove unused UI task types and dead-code allowance #14286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthonyshew merged 1 commit into from
Sep 26, 2026
Merged

refactor: Remove unused UI task types and dead-code allowance #14286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions crates/turborepo-ui/src/tui/task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#![allow(dead_code)]

@vercel vercel Bot Sep 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing #![allow(dead_code)] from task.rs leaves two unused pub methods (TasksByStatus::all_empty and Task<Finished>::end) that trigger the dead_code lint, breaking CI which builds with warnings-as-errors.

Fix on Vercel

use std::{collections::HashSet, mem, time::Instant};

use super::{Error, event::TaskResult};
Expand All @@ -24,12 +23,6 @@ pub struct Task<S> {
state: S,
}

pub enum TaskType {
Planned,
Running,
Finished,
}

impl<S> Task<S> {
pub fn name(&self) -> &str {
&self.name
Expand Down Expand Up @@ -103,13 +96,6 @@ impl Task<Finished> {
}
}

#[derive(Default)]
pub struct TaskNamesByStatus {
pub running: Vec<String>,
pub planned: Vec<String>,
pub finished: Vec<String>,
}

#[derive(Clone, Debug, Default)]
pub struct TasksByStatus {
pub running: Vec<Task<Running>>,
Expand Down
Loading