refactor: Separate prune closure and layout from JS rendering - #13545
Closed
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anthonyshew
force-pushed
the
shew/turbo-5833-extract-javascript-prune-rendering-pure-functions
branch
from
July 29, 2026 18:25
274fe33 to
7a55391
Compare
anthonyshew
force-pushed
the
shew/turbo-5834-separate-prune-closure-and-layout-from-js-rendering
branch
from
July 29, 2026 18:25
cf69b38 to
440c76b
Compare
anthonyshew
force-pushed
the
shew/turbo-5834-separate-prune-closure-and-layout-from-js-rendering
branch
from
July 29, 2026 18:27
440c76b to
d1f4372
Compare
anthonyshew
force-pushed
the
shew/turbo-5833-extract-javascript-prune-rendering-pure-functions
branch
from
July 29, 2026 18:27
7a55391 to
79dc088
Compare
anthonyshew
force-pushed
the
shew/turbo-5833-extract-javascript-prune-rendering-pure-functions
branch
from
July 29, 2026 18:50
79dc088 to
e24c787
Compare
anthonyshew
force-pushed
the
shew/turbo-5834-separate-prune-closure-and-layout-from-js-rendering
branch
from
July 29, 2026 18:50
d1f4372 to
1c87d9a
Compare
anthonyshew
force-pushed
the
shew/turbo-5834-separate-prune-closure-and-layout-from-js-rendering
branch
from
July 29, 2026 19:14
1c87d9a to
5623d92
Compare
anthonyshew
force-pushed
the
shew/turbo-5833-extract-javascript-prune-rendering-pure-functions
branch
from
July 29, 2026 19:14
e24c787 to
49581a9
Compare
Introduce an explicit JavaScript prune render step with typed inputs and artifacts so core orchestration no longer interleaves format rewriting with closure selection and path-safe layout. Closes TURBO-5834. Co-authored-by: Anthony Shew <anthonyshew@users.noreply.github.com>
anthonyshew
force-pushed
the
shew/turbo-5834-separate-prune-closure-and-layout-from-js-rendering
branch
from
July 29, 2026 19:31
5623d92 to
5d4486a
Compare
anthonyshew
force-pushed
the
shew/turbo-5833-extract-javascript-prune-rendering-pure-functions
branch
from
July 29, 2026 19:31
49581a9 to
1608b74
Compare
Contributor
Author
|
Batched into #13546 so the prune rendering extraction, layout separation, and golden coverage can be reviewed and validated together. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Continue Phase 7: core prune orchestration must treat JavaScript lockfile/manifest/patch rewriting as a distinct rendering step with explicit inputs/outputs, separate from package-closure selection and path-safe layout.
Stack: Phase 7 layer 2. Base =
shew/turbo-5833-extract-javascript-prune-rendering-pure-functions.Changes
render_javascript_prune+JavaScriptPruneRenderInput/JavaScriptPruneRenderResultinprune_js.rsprune.rsselects closures/layout first, then materializes the rendered JS artifactsOut of scope
Golden fixtures; deleting remaining JS compatibility projection.
Testing
cargo test -p turborepo-lib --lib commands::prune(15 passed)cargo clippy -p turborepo-lib --all-targets -- -D warningsCloses TURBO-5834.