fix: Isolate Cargo artifact outputs - #13359
Closed
anthonyshew wants to merge 1 commit into
Closed
anthonyshew wants to merge 1 commit into
anthonyshew wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Superseded by the reviewed stack:
The final stack was audited against this PR; all production behavior and test intent are represented, with additional fail-closed hardening. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cargo output wildcards could cache stale deliverables from another profile, target, target directory, or platform. Restoring those artifacts could corrupt builds, while log-only cache hits for unresolved layouts could suppress required Cargo execution.
What
Resolve and cache only exact effective Cargo deliverable paths across profile, target, target directory, and platform selection. Unknown or externally influenced layouts fail closed by disabling automatic caching while preserving explicit outputs and cache intent.
How
Pass narrowly projected, automatically hashed layout context into toolchain I/O derivation; use Cargo metadata and rustc host/target data; validate config, manifest, environment, argument, platform, and path-containment controls conservatively. Validated with 327 repository tests, complete engine/lib suites, 38 Cargo E2Es, cargo lint, cargo fmt, and final diff reviews.