fix: Ignore peer dependencies in package graph - #13029
Closed
anthonyshew wants to merge 1 commit into
Closed
anthonyshew wants to merge 1 commit into
anthonyshew wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Closing in favor of updating #13025 directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Turborepo should not treat
peerDependenciesas package graph inputs. Peers are supplied by consumers and should not create workspace build-order edges, participate in cycle detection, or influence package graph external dependency metadata.This fixes a regression where pure peer back-edges could make otherwise valid monorepos fail with circular package dependency errors.
What
dependencies,devDependencies, andoptionalDependencies.How
Run:
cargo test -p turborepo-repositoryManual reproduction:
appdepends onlibandlibdeclaresapponly as a peer.buildwithdependsOn: ["^build"].turbo run build.Expected result: Turbo builds
libbeforeappand does not report a package dependency cycle.