Skip to content

fix: Remove globwalk's expect() callsites #12871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthonyshew merged 1 commit into from
May 19, 2026
Merged

fix: Remove globwalk's expect() callsites #12871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions crates/turborepo-globwalk/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
//! but we do not support.

#![deny(clippy::all)]
#![allow(clippy::expect_used, clippy::unwrap_used)]
#![allow(clippy::unwrap_used)]
#![cfg_attr(test, allow(clippy::expect_used))]

use std::{
borrow::Cow,
Expand Down Expand Up @@ -143,9 +144,9 @@ pub fn fix_glob_pattern(pattern: &str) -> Cow<'_, str> {
// path-slash strips trailing slashes from Windows paths, so we need to restore
// them.
let needs_trailing_slash = pattern.ends_with('/') || pattern.ends_with('\\');
let converted = Path::new(pattern)
.to_slash()
.expect("failed to roundtrip through Path");
let Some(converted) = Path::new(pattern).to_slash() else {
return Cow::Borrowed(pattern);
};
if needs_trailing_slash && !converted.ends_with('/') {
Cow::Owned(format!("{converted}/"))
} else {
Expand Down Expand Up @@ -365,7 +366,13 @@ impl FromStr for ValidatedGlob {
// Only allocate when we actually need to clean
let path = Path::new(s);
let cleaned_path = path.clean();
Cow::Owned(cleaned_path.to_str().expect("valid utf-8").to_owned())
let Some(cleaned_str) = cleaned_path.to_str() else {
return Err(GlobError {
raw_input: s.to_owned(),
reason: "Path contains invalid UTF-8".to_owned(),
});
};
Cow::Owned(cleaned_str.to_owned())
} else {
Cow::Borrowed(s)
};
Expand Down Expand Up @@ -393,7 +400,12 @@ impl FromStr for ValidatedGlob {
let processed: Cow<'_, str> = if needs_slash_conversion || needs_cleaning {
let path = Path::new(s);
let cleaned_path = path.clean();
let cleaned_str = cleaned_path.to_str().expect("valid utf-8");
let Some(cleaned_str) = cleaned_path.to_str() else {
return Err(GlobError {
raw_input: s.to_owned(),
reason: "Path contains invalid UTF-8".to_owned(),
});
};
if needs_slash_conversion || cleaned_str.contains('\\') {
Cow::Owned(cleaned_str.replace('\\', "/"))
} else {
Expand Down
Loading