Skip to content

fix: Remove frameworks panic lint allows #12857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthonyshew merged 1 commit into from
May 18, 2026
Merged

fix: Remove frameworks panic lint allows #12857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions crates/turborepo-frameworks/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
//! Automatically identifies JavaScript frameworks and what environment
//! variables impact it.

#![allow(clippy::expect_used, clippy::unwrap_used)]

use std::{collections::HashMap, sync::OnceLock};

use serde::Deserialize;
Expand Down Expand Up @@ -74,15 +72,16 @@ impl Framework {
}
}

static FRAMEWORKS: OnceLock<Vec<Framework>> = OnceLock::new();
static FRAMEWORKS: OnceLock<Result<Vec<Framework>, serde_json::Error>> = OnceLock::new();

const FRAMEWORKS_JSON: &str =
include_str!("../../../packages/turbo-types/src/json/frameworks.json");

fn get_frameworks() -> &'static Vec<Framework> {
FRAMEWORKS.get_or_init(|| {
serde_json::from_str(FRAMEWORKS_JSON).expect("Unable to parse embedded JSON")
})
fn get_frameworks() -> Result<&'static [Framework], &'static serde_json::Error> {
FRAMEWORKS
.get_or_init(|| serde_json::from_str(FRAMEWORKS_JSON))
.as_ref()
.map(Vec::as_slice)
}

impl Matcher {
Expand Down Expand Up @@ -124,12 +123,11 @@ impl Slug {
&self.0
}

pub fn framework(&self) -> &Framework {
let frameworks = get_frameworks();
pub fn framework(&self) -> Option<&Framework> {
let frameworks = get_frameworks().ok()?;
frameworks
.iter()
.find(|framework| framework.slug.as_str() == self.as_str())
.expect("slug is only constructed via deserialization")
}
}

Expand All @@ -140,14 +138,15 @@ impl std::fmt::Display for Slug {
}

pub fn infer_framework(workspace: &PackageInfo, is_monorepo: bool) -> Option<&Framework> {
let frameworks = get_frameworks();
let frameworks = get_frameworks().ok()?;

frameworks
.iter()
.find(|framework| framework.dependency_match.test(workspace, is_monorepo))
}

#[cfg(test)]
#[allow(clippy::expect_used)]
mod tests {
use std::collections::{BTreeMap, HashMap};

Expand All @@ -158,6 +157,7 @@ mod tests {

fn get_framework_by_slug(slug: &str) -> &Framework {
get_frameworks()
.expect("framework JSON failed to parse")
.iter()
.find(|framework| framework.slug.as_str() == slug)
.expect("framework not found")
Expand Down Expand Up @@ -451,8 +451,8 @@ mod tests {

#[test]
fn test_framework_slug_roundtrip() {
for framework in get_frameworks() {
assert_eq!(framework, framework.slug().framework());
for framework in get_frameworks().expect("framework JSON failed to parse") {
assert_eq!(Some(framework), framework.slug().framework());
}
}
}
Loading