Improve accuracy in determining visibility state #4120
+67
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
shuding
reviewed
Nov 28, 2025
dcondrey
force-pushed
the
dcondrey-patch-2
branch
from
9a3a695 to
da40907
Compare
Enhanced visibility check. Resolves vercel#3039
no longer using isUndefined
dcondrey
force-pushed
the
dcondrey-patch-2
branch
3 times, most recently
from
d5b4d61 to
b2aadc1
Compare
dcondrey
force-pushed
the
dcondrey-patch-2
branch
from
b2aadc1 to
4a2c832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated isVisible() and hasFocus() and poll conditions independently.
Related Issues
Fixes #3039, #4130