Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 for files containing periods #726

Open
rburgst opened this issue Aug 22, 2022 · 0 comments
Open

404 for files containing periods #726

rburgst opened this issue Aug 22, 2022 · 0 comments

Comments

@rburgst
Copy link

rburgst commented Aug 22, 2022

Description

consider the follwing directory structure

- file.name.html
- file.name\
    - data.json

and the following config

		{
			trailingSlash: false,
			directoryListing: false,
                }

requesting http://localhost:3000/file.name will produce a 404 since dir listings are disabled and it does not search for file.name.html

Library version

14.0.1

Node version

16.13.1

abubakriz added a commit to abubakriz/serve-handler that referenced this issue Jul 31, 2024
When a file url has certain symbols like number sign (#), it doesn't encode them, which makes the browser fail to navigate to the file, thinking it is a document section. This commit fixes that by encoding urls using the built-in encodeURIComponent function.

Fixes vercel#120, vercel#205, vercel/serve#726, and vercel/serve#774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant