Fix regression in media layout with multiple images #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tywayne 👋 Thank you very much for the PR. I tested it locally and it looks good for 1, 2, and 4 images. The layout for 3 images looks very similar to the one for 2 but it should be more similar to the one for 4. E.g for https://twitter.com/JosngelGarcaBa3/status/1684679511974293506 
4 images looks real nice: 
|
|
@lfades Ahh yep, I missed that. Latest commit should fix it up. |
MikeKratzmann
approved these changes
Jul 28, 2023
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced in #99 inadvertently broke the media layouts when there is more than one image present (reported in #101).
The changes presented here will keep with the spirit of making the base theme match Twitter as closely as possible, while also supporting a grid of multiple images.