Fix fs readdir and readdirSync #1299
Conversation
|
Thank you for the PR. |
roberttod
force-pushed
the
main
branch
4 times, most recently
from
36ceb58 to
6038ed5
Compare
prelude/bootstrap.js
Outdated
| @@ -1969,29 +1969,31 @@ function payloadFileSync(pointer) { | |||
| // CHILD_PROCESS /////////////////////////////////////////////// | |||
| // ///////////////////////////////////////////////////////////// | |||
|
|
|||
| const customPromiseExecFunction = (o) => (...args) => { | |||
There was a problem hiding this comment.
Not sure how all these changes (this line and below) ended up here - I'll fix that.
There was a problem hiding this comment.
Actually, looks like this was applied by the prettier pre-commit hook so assume that's okay (unless you'd like me to skip the hook)
- When withFileTypes options is passed fs.readdir should be bootstrapped else it won't read from the snapshot
|
Hello, we are experiencing this issue #1130 using OCLIF and commands aren't showing in the built executable. I have pulled this PR and verified locally that it resolves our issue as well. I was wondering if there is anything we could help with to get this cleared for release? Thanks! |
There was a problem hiding this comment.
@roberttod could you revert changes to bootstrap.js dlopen method?
|
Superceded by #1495 . |
When used with
withFileTypes, fs does not work. This issue, and the remediation is explained in this issue #1130