fix: concat performance #422

styfle · 2024-06-03T13:31:16Z

styfle · 2024-06-03T17:15:26Z

src/utils/safe-stringify.ts

+  }
+  return value;
+};
+export function safeStringify(obj: unknown) {


We need a more comprehensive stringify to handle all possible inputs

styfle · 2024-06-03T17:16:37Z

src/utils/static-eval.ts

 type State = { computeBranches: boolean; vars: Record<string, any> };

+const walkCache = new Map<string, EvaluatedValue>();


We should probably use a LRU cache to avoid running out of memory. Right now, the number of entries is unbounded.

ojj1123 · 2024-07-04T07:20:36Z

Is this PR also related with vercel/next.js#65512 ?

thanks for reporting, we identified it to an issue with node-file-trace, but we're still unsure why concat messes with it

styfle added 2 commits June 3, 2024 06:29

add failing test

5be45fd

fix: add cache

d198252

styfle mentioned this pull request Jun 3, 2024

Many chained concat() calls can cause trace to fail #314

Open

styfle commented Jun 3, 2024

View reviewed changes

Merge branch 'main' into fix-issue-314

b31ca3e

Provide feedback

		type State = { computeBranches: boolean; vars: Record<string, any> };

		const walkCache = new Map<string, EvaluatedValue>();