Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace worker-farm with jest-worker #8496

Merged
merged 6 commits into from
Aug 24, 2019
Merged

Replace worker-farm with jest-worker #8496

merged 6 commits into from
Aug 24, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 23, 2019 •
edited by Timer
Loading

Removes worker-farm/serialize-javascript and replaces them with jest-worker.

Fixes #4647
Fixes #7766

@ijjk
Copy link
Member Author

ijjk commented Aug 23, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add-jest-worker Change
buildDuration 21.2s 21.8s ⚠️ +676ms
nodeModulesSize 41.2 MB 41.3 MB ⚠️ +62.4 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add-jest-worker Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add-jest-worker Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js add-jest-worker Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add-jest-worker Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add-jest-worker Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add-jest-worker Change
buildDuration 23.5s 25.4s ⚠️ +1.8s
nodeModulesSize 41.2 MB 41.3 MB ⚠️ +62.4 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add-jest-worker Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add-jest-worker Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js add-jest-worker Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add-jest-worker Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add-jest-worker Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary ijjk/next.js add-jest-worker Change
_error.js 247 kB 247 kB -8 B
_error.js gzip 66.2 kB 66.4 kB ⚠️ +161 B
hooks.html 3.81 kB 3.81 kB -3 B
hooks.html gzip 977 B 977 B ✓
index.js 248 kB 248 kB -8 B
index.js gzip 66.6 kB 66.7 kB ⚠️ +149 B
link.js 255 kB 255 kB -8 B
link.js gzip 68.8 kB 68.8 kB ⚠️ +87 B
routerDirect.js 249 kB 249 kB -8 B
routerDirect.js gzip 66.7 kB 66.7 kB ⚠️ +60 B
withRouter.js 248 kB 248 kB -8 B
withRouter.js gzip 66.8 kB 66.6 kB -261 B
Overall change -43 B

Timer
Timer requested changes Aug 23, 2019
View reviewed changes
packages/next/build/index.ts Show resolved Hide resolved
packages/next/build/webpack/plugins/terser-webpack-plugin/src/TaskRunner.js Outdated Show resolved Hide resolved
packages/next/build/webpack/plugins/terser-webpack-plugin/src/TaskRunner.js Outdated Show resolved Hide resolved
packages/next/build/webpack/plugins/terser-webpack-plugin/src/TaskRunner.js Outdated Show resolved Hide resolved
packages/next/build/webpack/plugins/terser-webpack-plugin/src/TaskRunner.js Outdated Show resolved Hide resolved
packages/next/build/webpack/plugins/terser-webpack-plugin/src/TaskRunner.js Outdated Show resolved Hide resolved
packages/next/build/webpack/plugins/terser-webpack-plugin/src/TaskRunner.js Outdated Show resolved Hide resolved
packages/next/build/webpack/plugins/terser-webpack-plugin/src/TaskRunner.js Outdated Show resolved Hide resolved
packages/next/build/webpack/plugins/terser-webpack-plugin/src/TaskRunner.js Outdated Show resolved Hide resolved
Timer
Timer requested changes Aug 23, 2019
View reviewed changes
packages/next/build/webpack/plugins/terser-webpack-plugin/src/worker.js Outdated Show resolved Hide resolved
packages/next/build/index.ts Outdated Show resolved Hide resolved
@ijjk
Copy link
Member Author

ijjk commented Aug 24, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add-jest-worker Change
buildDuration 22.3s 22.1s -186ms
nodeModulesSize 41.2 MB 41.3 MB ⚠️ +62 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add-jest-worker Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add-jest-worker Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js add-jest-worker Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add-jest-worker Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add-jest-worker Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add-jest-worker Change
buildDuration 24.4s 24.2s -222ms
nodeModulesSize 41.2 MB 41.3 MB ⚠️ +62 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add-jest-worker Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add-jest-worker Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.36 kB 6.36 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js add-jest-worker Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add-jest-worker Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add-jest-worker Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary ijjk/next.js add-jest-worker Change
_error.js 247 kB 247 kB ✓
_error.js gzip 66.4 kB 66.4 kB ⚠️ +1 B
hooks.html 3.81 kB 3.81 kB ✓
hooks.html gzip 975 B 977 B ⚠️ +2 B
index.js 248 kB 248 kB ✓
index.js gzip 66.7 kB 66.7 kB -33 B
link.js 255 kB 255 kB ✓
link.js gzip 68.8 kB 68.7 kB -137 B
routerDirect.js 249 kB 249 kB ✓
routerDirect.js gzip 66.6 kB 66.6 kB ⚠️ +63 B
withRouter.js 248 kB 248 kB ✓
withRouter.js gzip 66.6 kB 66.7 kB ⚠️ +60 B
Overall change ✓

@ijjk
Copy link
Member Author

ijjk commented Aug 24, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add-jest-worker Change
buildDuration 23.6s 23.4s -192ms
nodeModulesSize 41.2 MB 41.3 MB ⚠️ +61.1 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add-jest-worker Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.64 kB 6.64 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add-jest-worker Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.37 kB 6.37 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js add-jest-worker Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add-jest-worker Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add-jest-worker Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Rendered Page Sizes Overall increase ⚠️
zeit/next.js canary ijjk/next.js add-jest-worker Change
index.html 3.69 kB 3.69 kB ⚠️ +3 B
index.html gzip 955 B 959 B ⚠️ +4 B
link.html 3.74 kB 3.74 kB ⚠️ +3 B
link.html gzip 964 B 968 B ⚠️ +4 B
withRouter.html 3.75 kB 3.75 kB ⚠️ +3 B
withRouter.html gzip 950 B 955 B ⚠️ +5 B
Overall change ⚠️ +9 B

Diffs

Diff for main-HASH.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
Diff for main-HASH.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
Diff for _app.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "B5Ud":
 /***/ (function(module, exports, __webpack_require__) {
Diff for _error.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {
Diff for hooks.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for index.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for link.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
Diff for routerDirect.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {
Diff for withRouter.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for _app.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
Diff for _error.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {
Diff for hooks.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for index.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for link.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
Diff for routerDirect.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {
Diff for withRouter.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for index.html 
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/NzVavano2P1kNmmRhMLzM/pages/index.module.js"
+        <link rel="preload" href="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/index.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/NzVavano2P1kNmmRhMLzM/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-57fd58f9724110a1d2ca.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/KptZlOTZwSDjzQtRwvGB8y9ZYo=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/4xixvm7YpVwKIXXMT0PZaZm1D+s=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/NzVavano2P1kNmmRhMLzM/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/scXnk1WWgOXzqugyGU3VS/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -26,40 +26,40 @@
         <div id="__next">Hello world 👋</div>
         <script id="__NEXT_DATA__" type="application/json"
         crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"NzVavano2P1kNmmRhMLzM"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/","query":{},"buildId":"scXnk1WWgOXzqugyGU3VS"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/" src="/_next/static/NzVavano2P1kNmmRhMLzM/pages/index.js"
+        <script async="" data-next-page="/" src="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/" src="/_next/static/NzVavano2P1kNmmRhMLzM/pages/index.module.js"
+        <script async="" data-next-page="/" src="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/index.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/NzVavano2P1kNmmRhMLzM/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/NzVavano2P1kNmmRhMLzM/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
+        <script src="/_next/static/runtime/main-758fcb9b9994c6769dbb.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <script src="/_next/static/runtime/main-57fd58f9724110a1d2ca.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/+QATEkzP89Ad53IC1yRuxvB23w=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/63UgzG2Jn9a5Xr5AslgCks65pA=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/KptZlOTZwSDjzQtRwvGB8y9ZYo=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/4xixvm7YpVwKIXXMT0PZaZm1D+s=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/KptZlOTZwSDjzQtRwvGB8y9ZYo=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/4xixvm7YpVwKIXXMT0PZaZm1D+s=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/NzVavano2P1kNmmRhMLzM/_buildManifest.js"
+        <script src="/_next/static/scXnk1WWgOXzqugyGU3VS/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/NzVavano2P1kNmmRhMLzM/_buildManifest.module.js"
+        <script src="/_next/static/scXnk1WWgOXzqugyGU3VS/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for link.html 
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/NzVavano2P1kNmmRhMLzM/pages/link.module.js"
+        <link rel="preload" href="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/link.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/NzVavano2P1kNmmRhMLzM/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/KptZlOTZwSDjzQtRwvGB8y9ZYo=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/4xixvm7YpVwKIXXMT0PZaZm1D+s=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-57fd58f9724110a1d2ca.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/NzVavano2P1kNmmRhMLzM/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/scXnk1WWgOXzqugyGU3VS/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -29,18 +29,18 @@
             </div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"NzVavano2P1kNmmRhMLzM"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/link","query":{},"buildId":"scXnk1WWgOXzqugyGU3VS"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/link" src="/_next/static/NzVavano2P1kNmmRhMLzM/pages/link.js"
+        <script async="" data-next-page="/link" src="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/link" src="/_next/static/NzVavano2P1kNmmRhMLzM/pages/link.module.js"
+        <script async="" data-next-page="/link" src="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/link.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/NzVavano2P1kNmmRhMLzM/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/NzVavano2P1kNmmRhMLzM/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -50,19 +50,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/+QATEkzP89Ad53IC1yRuxvB23w=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/63UgzG2Jn9a5Xr5AslgCks65pA=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/KptZlOTZwSDjzQtRwvGB8y9ZYo=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/4xixvm7YpVwKIXXMT0PZaZm1D+s=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/KptZlOTZwSDjzQtRwvGB8y9ZYo=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/4xixvm7YpVwKIXXMT0PZaZm1D+s=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
+        <script src="/_next/static/runtime/main-758fcb9b9994c6769dbb.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <script src="/_next/static/runtime/main-57fd58f9724110a1d2ca.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/NzVavano2P1kNmmRhMLzM/_buildManifest.js"
+        <script src="/_next/static/scXnk1WWgOXzqugyGU3VS/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/NzVavano2P1kNmmRhMLzM/_buildManifest.module.js"
+        <script src="/_next/static/scXnk1WWgOXzqugyGU3VS/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Diff for withRouter.html 
@@ -6,19 +6,19 @@
         <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"
         />
         <meta name="next-head-count" content="2" />
-        <link rel="preload" href="/_next/static/NzVavano2P1kNmmRhMLzM/pages/withRouter.module.js"
+        <link rel="preload" href="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/withRouter.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/NzVavano2P1kNmmRhMLzM/pages/_app.module.js"
+        <link rel="preload" href="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/_app.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/KptZlOTZwSDjzQtRwvGB8y9ZYo=.72ab6ea1ebeafbd8c735.module.js"
+        <link rel="preload" href="/_next/static/chunks/4xixvm7YpVwKIXXMT0PZaZm1D+s=.72ab6ea1ebeafbd8c735.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-57fd58f9724110a1d2ca.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/NzVavano2P1kNmmRhMLzM/_buildManifest.module.js"
+        <link rel="preload" href="/_next/static/scXnk1WWgOXzqugyGU3VS/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -27,18 +27,18 @@
             <div>I use withRouter</div>
         </div>
         <script id="__NEXT_DATA__" type="application/json" crossorigin="anonymous">
-            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"NzVavano2P1kNmmRhMLzM"}
+            {"dataManager":"[]","props":{"pageProps":{}},"page":"/withRouter","query":{},"buildId":"scXnk1WWgOXzqugyGU3VS"}
         </script>
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/NzVavano2P1kNmmRhMLzM/pages/withRouter.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/withRouter" src="/_next/static/NzVavano2P1kNmmRhMLzM/pages/withRouter.module.js"
+        <script async="" data-next-page="/withRouter" src="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/withRouter.module.js"
         crossorigin="anonymous" type="module"></script>
-        <script async="" data-next-page="/_app" src="/_next/static/NzVavano2P1kNmmRhMLzM/pages/_app.js"
+        <script async="" data-next-page="/_app" src="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/_app.js"
         crossorigin="anonymous" nomodule=""></script>
-        <script async="" data-next-page="/_app" src="/_next/static/NzVavano2P1kNmmRhMLzM/pages/_app.module.js"
+        <script async="" data-next-page="/_app" src="/_next/static/scXnk1WWgOXzqugyGU3VS/pages/_app.module.js"
         crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -48,19 +48,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/+QATEkzP89Ad53IC1yRuxvB23w=.155621535702fe040780.js"
+        <script src="/_next/static/chunks/63UgzG2Jn9a5Xr5AslgCks65pA=.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/KptZlOTZwSDjzQtRwvGB8y9ZYo=.c99adde05e467047c83e.js"
+        <script src="/_next/static/chunks/4xixvm7YpVwKIXXMT0PZaZm1D+s=.c99adde05e467047c83e.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/KptZlOTZwSDjzQtRwvGB8y9ZYo=.72ab6ea1ebeafbd8c735.module.js"
+        <script src="/_next/static/chunks/4xixvm7YpVwKIXXMT0PZaZm1D+s=.72ab6ea1ebeafbd8c735.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-97617d800ec2b207a20a.js"
+        <script src="/_next/static/runtime/main-758fcb9b9994c6769dbb.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-9c0b8b62a2fb27af35b2.module.js"
+        <script src="/_next/static/runtime/main-57fd58f9724110a1d2ca.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/NzVavano2P1kNmmRhMLzM/_buildManifest.js"
+        <script src="/_next/static/scXnk1WWgOXzqugyGU3VS/_buildManifest.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/NzVavano2P1kNmmRhMLzM/_buildManifest.module.js"
+        <script src="/_next/static/scXnk1WWgOXzqugyGU3VS/_buildManifest.module.js"
         async="" crossorigin="anonymous" type="module"></script>
     </body>
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add-jest-worker Change
buildDuration 25s 25.3s ⚠️ +263ms
nodeModulesSize 41.2 MB 41.3 MB ⚠️ +61.1 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add-jest-worker Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.64 kB 6.64 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add-jest-worker Change
main-HASH.module.js 16.5 kB 16.5 kB ✓
main-HASH.module.js gzip 6.37 kB 6.37 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
Overall change ✓
Client Pages
zeit/next.js canary ijjk/next.js add-jest-worker Change
_app.js 1.83 kB 1.83 kB ✓
_app.js gzip 884 B 884 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.81 kB 4.81 kB ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 433 B 433 B ✓
routerDirect.js gzip 296 B 296 B ✓
withRouter.js 444 B 444 B ✓
withRouter.js gzip 294 B 294 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add-jest-worker Change
_app.module.js 1.73 kB 1.73 kB ✓
_app.module.js gzip 840 B 840 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.62 kB 8.62 kB ✓
hooks.module.js 1.55 kB 1.55 kB ✓
hooks.module.js gzip 804 B 804 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 419 B 419 B ✓
routerDirect.module.js gzip 294 B 294 B ✓
withRouter.module.js 429 B 429 B ✓
withRouter.module.js gzip 293 B 293 B ✓
Overall change ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add-jest-worker Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManifest.module.js gzip 61 B 61 B ✓
Overall change ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary ijjk/next.js add-jest-worker Change
_error.js 247 kB 247 kB -5 B
_error.js gzip 66.2 kB 66.3 kB ⚠️ +17 B
hooks.html 3.81 kB 3.81 kB -1 B
hooks.html gzip 981 B 981 B ✓
index.js 248 kB 248 kB -5 B
index.js gzip 66.6 kB 66.5 kB -97 B
link.js 255 kB 255 kB -5 B
link.js gzip 68.8 kB 68.8 kB ⚠️ +17 B
routerDirect.js 249 kB 249 kB -5 B
routerDirect.js gzip 66.6 kB 66.6 kB -7 B
withRouter.js 248 kB 248 kB -5 B
withRouter.js gzip 66.6 kB 66.6 kB ✓
Overall change -26 B

@Timer Timer added this to the 9.0.6 milestone Aug 24, 2019
Timer
Timer approved these changes Aug 24, 2019
View reviewed changes
Copy link
Member

@Timer Timer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This gives us a great advantage for Docker and Windows users!

@Timer Timer merged commit f81b6d5 into vercel:canary Aug 24, 2019
@ijjk ijjk deleted the add-jest-worker branch August 24, 2019 19:06
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.6
Development

Successfully merging this pull request may close these issues.

Build process doesn't end npm run build hangs forever
2 participants
@ijjk @Timer