fix: Use standard PostCSS configuration in create-next-app format for ecosystem compatibility (part 2)#84122
Closed
ndelangen wants to merge 2 commits into
Closed
fix: Use standard PostCSS configuration in create-next-app format for ecosystem compatibility (part 2)#84122ndelangen wants to merge 2 commits into
ndelangen wants to merge 2 commits into
Conversation
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Contributor
|
cf #79949 |
Contributor
|
@ndelangen #79949 has been merged so i think this one can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #77376 by @kasperpeulen
This PR continues what was done there, converting the remainning template postcss config files to the standard format.
Why?
The array string format for PostCSS plugins is non-standard, and gives errors when loading using postcss-load-config:
TypeError: Invalid PostCSS Plugin found at: plugins[0]
This change ensures that Next.js applications using Tailwind CSS can seamlessly integrate with these tools without requiring manual configuration fixes. For example, vitest will crash, which uses postcss-load-config under the hood:
storybookjs/storybook#30878
How?
Modified the PostCSS configuration in both JavaScript and TypeScript empty app templates with Tailwind to use the object-based plugin format, which is the standard format recognized by PostCSS tools in the ecosystem.
Array syntax:
Object syntax