[use-cache] track cache read earlier when encrypting bound args #81427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnoff
commented
Jul 8, 2025
|
|
||
| async function getUncachedData() { | ||
| await setTimeout(100) | ||
| await setTimeout(0) |
Contributor
Author
There was a problem hiding this comment.
restoring these back to their intended timeout. Suspect that a prior fix to module loading tracking in dev made this possible
|
|
||
| async function fetchUncachedData() { | ||
| await setTimeout(100) | ||
| await setTimeout(0) |
Contributor
Author
There was a problem hiding this comment.
restoring these back to their intended timeout. Suspect that a prior fix to module loading tracking in dev made this possible
unstubbable
approved these changes
Jul 8, 2025
Member
Tests Passed |
lubieowoce
reviewed
Jul 8, 2025
bound args need to be encrypted for use cache functions and currently we track the read slightly later than will be necessary when we sync the latest React. This change moves the tracking to be as early as possible (as soon as the input signal is aborted or when the bound args are finished being serialized, whichever is first).
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+136
to
+137
| // missing this cache fill. We use a idempotent function to only start reading once because | ||
| // it's also possible that streamToString finishes before the hangingInputAbortSignal aborts. |
Contributor
There was a problem hiding this comment.
The comment has a minor grammatical error: "a idempotent function" should be "an idempotent function" since "idempotent" begins with a vowel sound.
Suggested change
| // missing this cache fill. We use a idempotent function to only start reading once because | |
| // it's also possible that streamToString finishes before the hangingInputAbortSignal aborts. | |
| // missing this cache fill. We use an idempotent function to only start reading once because | |
| // it's also possible that streamToString finishes before the hangingInputAbortSignal aborts. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
RobPruzan
pushed a commit
that referenced
this pull request
Jul 8, 2025
bound args need to be encrypted for use cache functions and currently we track the read slightly later than will be necessary when we sync the latest React. This change moves the tracking to be as early as possible (as soon as the input signal is aborted or when the bound args are finished being serialized, whichever is first).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bound args need to be encrypted for use cache functions and currently we track the read slightly later than will be necessary when we sync the latest React. This change moves the tracking to be as early as possible (as soon as the input signal is aborted or when the bound args are finished being serialized, whichever is first).