Turbopack: make another callback return a result - #80608
Merged
Merged
Conversation
ijjk
added
created-by: Turbopack team
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mischnic
marked this pull request as ready for review
June 17, 2025 10:16
This was referenced Jun 17, 2025
mischnic
force-pushed
the
mischnic/traverse-callback-result
branch
from
June 17, 2025 10:44
7025320 to
1cc5467
Compare
CodSpeed Performance ReportMerging #80608 will not alter performanceComparing Summary
|
lukesandberg
approved these changes
Jun 17, 2025
lukesandberg
left a comment
lukesandberg
left a comment
Contributor
There was a problem hiding this comment.
ah, eventual consistency...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already do this in a bunch of these callbacks, because sometimes you have some
Option<>in there that you know is always set. Except for eventual consistency, unfortunately. That's the main usecase for a result here.Closes PACK-4848