-
Notifications
You must be signed in to change notification settings - Fork 31.8k
[devtools] apply tailwind to storybook #80449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
devjiwonchoi
wants to merge
3
commits into
jiwon/06-10-_devtools_initialize_tailwind
from
jiwon/06-12-_devtools_apply_tailwind_to_storybook
+40
−0
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,6 +37,14 @@ export function ShadowPortal({ children }: { children: React.ReactNode }) { | |
| if (portalNode.current.shadowRoot === null) { | ||
| shadowNode.current = portalNode.current.attachShadow({ mode: 'open' }) | ||
|
|
||
| // Storybook injects the Tailwind style tag from .storybook/main.ts on each full load. | ||
| // When navigating to a different story, the injected style tag is removed within the iframe. | ||
| // To re-inject the style tag, we need to call `unuse()` since the `use()` function only runs | ||
| // once unless unused. | ||
| if (process.env.STORYBOOK) { | ||
| tailwindCss.unuse() | ||
| } | ||
|
Comment on lines
+44
to
+46
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't this problematic because it leaks into our published bundle? Why can't this be handled within Storybook? Whatever is injecting the stylesheet in our user bundle should always be used in our Storybook instead of having custom Storybook specific logic in the bundle. |
||
|
|
||
| // Injecting Tailwind to the Shadow DOM with Webpack style-loader. | ||
| // The target is passed to the next-devtools-inject-tailwind.js file which runs on the browser. | ||
| // x-ref: https://webpack.js.org/loaders/style-loader/#lazystyletag | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You never want optional chaining here and instead is non-null assertions. The rule must always be appended.