Repository navigation
perf(turbopack): Detect more immutable tasks #80423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,9 +52,10 @@ impl ConnectChildOperation { | |
| }; | ||
|
|
||
| // Quick skip if the child was already connected before | ||
| if !new_children.insert(child_task_id) { | ||
| if new_children.insert(child_task_id, is_immutable).is_some() { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The logic here needs to be adjusted after changing from To maintain the original behavior of skipping when a child is already connected, the condition should be: if new_children.contains_key(&child_task_id) {
return;
}
new_children.insert(child_task_id, is_immutable);Or alternatively: if let Some(_) = new_children.insert(child_task_id, is_immutable) {
return;
}Spotted by Diamond
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I made it use only a static flag to know the perf difference of using a dynamic flag using codspeed. See #80506 |
||
| return; | ||
| } | ||
|
|
||
| if parent_task.has_key(&CachedDataItemKey::Child { | ||
| task: child_task_id, | ||
| }) { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.