Skip to content

[DevOverlay] Enable reactOwnerStack when newDevOverlay is enabled #75199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devjiwonchoi merged 4 commits into from
Jan 23, 2025
Merged

[DevOverlay] Enable reactOwnerStack when newDevOverlay is enabled #75199

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d66d83b
[DevOverlay] Enable reactOwnerStack when newDevOverlay is enabled
devjiwonchoi Jan 22, 2025
dddb3f5
enable new overlay when owner stack
devjiwonchoi Jan 23, 2025
154e6fd
donot touch default config
devjiwonchoi Jan 23, 2025
b66a0be
enable react owner stack when new dev overlay on load config stage
devjiwonchoi Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/next/src/server/config-shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1234,7 +1234,14 @@ export const defaultConfig: NextConfig = {
staticGenerationMinPagesPerWorker: 25,
dynamicIO: false,
inlineCss: false,
newDevOverlay: false,
// TODO: remove once we've made new UI default
get newDevOverlay() {

@huozhi huozhi Jan 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default value, it should be false. turning on the flag should be done in load config.
The config will also be serialized in output manifest, I'd prefer we keep the default config flag and simple

return (
// Enable reactOwnerStack when newDevOverlay is enabled to have
// better call stack output in the new UI.
Object.getOwnPropertyDescriptor(this, 'reactOwnerStack')?.value ?? false
)
},
streamingMetadata: false,
htmlLimitedBots: undefined,
},
Expand Down