Skip to content

[DevOverlay] Gather Feedback per Error #74908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devjiwonchoi merged 1 commit into from
Jan 16, 2025
+47 −36
Merged

[DevOverlay] Gather Feedback per Error #74908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 35 additions & 32 deletions ...imental/internal/components/Errors/error-overlay-footer/error-feedback/error-feedback.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,18 @@ interface ErrorFeedbackProps {
errorCode: string
}
export function ErrorFeedback({ errorCode }: ErrorFeedbackProps) {
const [voted, setVoted] = useState<boolean | null>(null)
const hasVoted = voted !== null
const [votedMap, setVotedMap] = useState<Record<string, boolean>>({})
const voted = votedMap[errorCode]
const hasVoted = voted !== undefined

const handleFeedback = useCallback(
async (wasHelpful: boolean) => {
// Optimistically set feedback state without loading/error states to keep implementation simple
setVoted(wasHelpful)
setVotedMap((prev) => ({
...prev,
[errorCode]: wasHelpful,
}))

try {
const response = await fetch(
`${process.env.__NEXT_ROUTER_BASEPATH || ''}/__nextjs_error_feedback?${new URLSearchParams(
Expand All @@ -36,35 +41,33 @@ export function ErrorFeedback({ errorCode }: ErrorFeedbackProps) {
)

return (
<>
<div className="error-feedback" role="region" aria-label="Error feedback">
{hasVoted ? (
<p className="error-feedback-thanks" role="status" aria-live="polite">
Thanks for your feedback!
</p>
) : (
<>
<p>Was this helpful?</p>
<button
aria-label="Mark as helpful"
onClick={() => handleFeedback(true)}
className={`feedback-button ${voted === true ? 'voted' : ''}`}
type="button"
>
<ThumbsUp aria-hidden="true" />
</button>
<button
aria-label="Mark as not helpful"
onClick={() => handleFeedback(false)}
className={`feedback-button ${voted === false ? 'voted' : ''}`}
type="button"
>
<ThumbsDown aria-hidden="true" />
</button>
</>
)}
</div>
</>
<div className="error-feedback" role="region" aria-label="Error feedback">
{hasVoted ? (
<p className="error-feedback-thanks" role="status" aria-live="polite">
Thanks for your feedback!
</p>
) : (
<>
<p>Was this helpful?</p>
<button
aria-label="Mark as helpful"
onClick={() => handleFeedback(true)}
className={`feedback-button ${voted === true ? 'voted' : ''}`}
type="button"
>
<ThumbsUp aria-hidden="true" />
</button>
<button
aria-label="Mark as not helpful"
onClick={() => handleFeedback(false)}
className={`feedback-button ${voted === false ? 'voted' : ''}`}
type="button"
>
<ThumbsDown aria-hidden="true" />
</button>
</>
)}
</div>
)
}

Expand Down
16 changes: 12 additions & 4 deletions ...c/client/components/react-dev-overlay/_experimental/internal/container/Errors.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ export const Default: Story = {
id: 1,
event: {
type: ACTION_UNHANDLED_ERROR,
reason: new Error('First error message'),
reason: Object.assign(new Error('First error message'), {
__NEXT_ERROR_CODE: 'E001',
}),
componentStackFrames: [
{
file: 'app/page.tsx',
Expand All @@ -47,23 +49,29 @@ export const Default: Story = {
id: 2,
event: {
type: ACTION_UNHANDLED_ERROR,
reason: new Error('Second error message'),
reason: Object.assign(new Error('Second error message'), {
__NEXT_ERROR_CODE: 'E002',
}),
frames: [],
},
},
{
id: 3,
event: {
type: ACTION_UNHANDLED_ERROR,
reason: new Error('Third error message'),
reason: Object.assign(new Error('Third error message'), {
__NEXT_ERROR_CODE: 'E003',
}),
frames: [],
},
},
{
id: 4,
event: {
type: ACTION_UNHANDLED_ERROR,
reason: new Error('Fourth error message'),
reason: Object.assign(new Error('Fourth error message'), {
__NEXT_ERROR_CODE: 'E004',
}),
frames: [],
},
},
Expand Down