-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade React from 7283a213-20241206
to 79ddf5b5-20241210
#73804
Conversation
Failing test suitesCommit: 77ee504
Expand output● dynamic-io › should not have dynamic IO errors when encoding bound args for inline server actions
Read more about building and testing Next.js in contributing.md.
Expand output● dynamic-io › should prerender pages that cached the whole page
Read more about building and testing Next.js in contributing.md.
Expand output● use-cache › should dedupe with react cache inside "use cache"
● use-cache › should error when cookies/headers/draftMode is used inside "use cache"
Read more about building and testing Next.js in contributing.md.
Expand output● static-shell-debugging › ppr = true, debugging = true › should only render the static shell
● static-shell-debugging › ppr = true, debugging = true › should skip hydration to avoid blanking out the page
Read more about building and testing Next.js in contributing.md.
Expand output● persistent-caching › should allow to change files while stopped
Read more about building and testing Next.js in contributing.md. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected] |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js update/react/79ddf5b5-20241210 | Change | |
---|---|---|---|
buildDuration | 24.1s | 21.9s | N/A |
buildDurationCached | 19.9s | 17.5s | N/A |
nodeModulesSize | 410 MB | 410 MB | N/A |
nextStartRea..uration (ms) | 577ms | 575ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js update/react/79ddf5b5-20241210 | Change | |
---|---|---|---|
1187-HASH.js gzip | 50.9 kB | 50.9 kB | ✓ |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.36 kB | 5.36 kB | N/A |
bccd1874-HASH.js gzip | 53 kB | 52.9 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 232 B | 235 B | N/A |
main-HASH.js gzip | 34.1 kB | 34 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 50.9 kB | 50.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js update/react/79ddf5b5-20241210 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js update/react/79ddf5b5-20241210 | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.49 kB | 4.49 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js update/react/79ddf5b5-20241210 | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 746 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js update/react/79ddf5b5-20241210 | Change | |
---|---|---|---|
index.html gzip | 524 B | 524 B | ✓ |
link.html gzip | 539 B | 538 B | N/A |
withRouter.html gzip | 519 B | 520 B | N/A |
Overall change | 524 B | 524 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js update/react/79ddf5b5-20241210 | Change | |
---|---|---|---|
edge-ssr.js gzip | 128 kB | 128 kB | N/A |
page.js gzip | 204 kB | 204 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js update/react/79ddf5b5-20241210 | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 671 B | 667 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.2 kB | 31.2 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes Overall increase ⚠️
vercel/next.js canary | vercel/next.js update/react/79ddf5b5-20241210 | Change | |
---|---|---|---|
523-experime...dev.js gzip | 322 B | 322 B | ✓ |
523.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 323 kB | 323 kB | N/A |
app-page-exp..prod.js gzip | 127 kB | 127 kB | N/A |
app-page-tur..prod.js gzip | 140 kB | 140 kB | N/A |
app-page-tur..prod.js gzip | 135 kB | 136 kB | |
app-page.run...dev.js gzip | 314 kB | 314 kB | |
app-page.run..prod.js gzip | 123 kB | 123 kB | |
app-route-ex...dev.js gzip | 37.4 kB | 37.4 kB | ✓ |
app-route-ex..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
app-route-tu..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
app-route-tu..prod.js gzip | 25.3 kB | 25.3 kB | ✓ |
app-route.ru...dev.js gzip | 39 kB | 39 kB | N/A |
app-route.ru..prod.js gzip | 25.3 kB | 25.3 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
pages.runtim...dev.js gzip | 27.4 kB | 27.4 kB | ✓ |
pages.runtim..prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | N/A |
Overall change | 813 kB | 814 kB |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js update/react/79ddf5b5-20241210 | Change | |
---|---|---|---|
0.pack gzip | 2.05 MB | 2.05 MB | |
index.pack gzip | 72.1 kB | 72.6 kB | |
Overall change | 2.12 MB | 2.13 MB |
Diff details
Diff for 1187-HASH.js
Diff too large to display
Diff for bccd1874-HASH.js
@@ -1,13 +1,13 @@
"use strict";
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
- [7629],
+ [1758],
{
- /***/ 641: /***/ (
+ /***/ 8699: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
) => {
- /* provided dependency */ var process = __webpack_require__(6611);
+ /* provided dependency */ var process = __webpack_require__(9829);
/**
* @license React
* react-dom-client.production.js
@@ -22,9 +22,9 @@
Modernizr 3.0.0pre (Custom Build) | MIT
*/
- var Scheduler = __webpack_require__(8684),
- React = __webpack_require__(1446),
- ReactDOM = __webpack_require__(8307);
+ var Scheduler = __webpack_require__(462),
+ React = __webpack_require__(228),
+ ReactDOM = __webpack_require__(9221);
function formatProdErrorMessage(code) {
var url = "https://react.dev/errors/" + code;
if (1 < arguments.length) {
@@ -16111,14 +16111,14 @@
};
var isomorphicReactPackageVersion$jscomp$inline_1683 = React.version;
if (
- "19.0.0-rc-7283a213-20241206" !==
+ "19.0.0-rc-79ddf5b5-20241210" !==
isomorphicReactPackageVersion$jscomp$inline_1683
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1683,
- "19.0.0-rc-7283a213-20241206"
+ "19.0.0-rc-79ddf5b5-20241210"
)
);
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16140,11 +16140,10 @@
};
var internals$jscomp$inline_2159 = {
bundleType: 0,
- version: "19.0.0-rc-7283a213-20241206",
+ version: "19.0.0-rc-79ddf5b5-20241210",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
- findFiberByHostInstance: getClosestInstanceFromNode,
- reconcilerVersion: "19.0.0-rc-7283a213-20241206",
+ reconcilerVersion: "19.0.0-rc-79ddf5b5-20241210",
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2160 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16252,7 +16251,7 @@
listenToAllSupportedEvents(container);
return new ReactDOMHydrationRoot(initialChildren);
};
- exports.version = "19.0.0-rc-7283a213-20241206";
+ exports.version = "19.0.0-rc-79ddf5b5-20241210";
/***/
},
Diff for main-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js
Diff too large to display
Diff for server.runtime.prod.js
failed to diff
9ca18b7
to
77ee504
Compare
Before calling `emitTimingChunk` inside of `forwardDebugInfo`, we must not increment `request.pendingChunks`, as this is already done inside of the `emitTimingChunk` function. I don't have a unit test for this, but manually verified that this fixes the hanging responses in vercel/next.js#73804.
Blocked on facebook/react#31833 |
Before calling `emitTimingChunk` inside of `forwardDebugInfo`, we must not increment `request.pendingChunks`, as this is already done inside of the `emitTimingChunk` function. I don't have a unit test for this, but manually verified that this fixes the hanging responses in vercel/next.js#73804.
diff facebook/[email protected]
React upstream changes
do/while
loops facebook/react#31720prerender
tounstable_prerender
and include in stable channel facebook/react#31724