-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(next): add cross origin in react dom preload #67423
Merged
eps1lon
merged 5 commits into
vercel:canary
from
syi0808:fix/preload-link-tag-missing-cross-origin
Jul 5, 2024
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6198214
fix(next): add cross origin in reactdom preload
syi0808 8d84220
test(next): add test for next script crossorigin in app dir
syi0808 baf199f
test: createNext to nextTestSetup with pnpm new-test command
syi0808 65034bd
refactor: clean up test
syi0808 83d55ed
Merge branch 'canary' into fix/preload-link-tag-missing-cross-origin
devjiwonchoi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export default function Layout({ children }) { | ||
return ( | ||
<html> | ||
<body>{children}</body> | ||
</html> | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import Script from 'next/script' | ||
|
||
export default function Page() { | ||
return ( | ||
<Script | ||
src="https://code.jquery.com/jquery-3.7.1.min.js" | ||
crossOrigin="use-credentials" | ||
/> | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import { createNext } from 'e2e-utils' | ||
import { NextInstance } from '../../../lib/next-modes/base' | ||
import { BrowserInterface } from '../../../lib/browsers/base' | ||
|
||
describe('Script component with crossOrigin props', () => { | ||
let next: NextInstance | ||
|
||
beforeAll(async () => { | ||
next = await createNext({ | ||
files: __dirname, | ||
}) | ||
}) | ||
afterAll(() => next.destroy()) | ||
|
||
it('should be set crossOrigin also in preload link tag', async () => { | ||
let browser: BrowserInterface | ||
|
||
try { | ||
browser = await next.browser('/') | ||
|
||
expect( | ||
await browser | ||
.elementByCss( | ||
'link[href="https://code.jquery.com/jquery-3.7.1.min.js"]' | ||
) | ||
.getAttribute('crossorigin') | ||
).toBe('use-credentials') | ||
} finally { | ||
if (browser) await browser.close() | ||
} | ||
}) | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move to
nextTestSetup
? You can easily generate viapnpm new-test
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing command! It's awesome. I created new test with
pnpm new-test
now.