NODE_OPTIONS updates #65006

wyattjoh · 2024-04-24T21:49:55Z

What?

Previously, parsing and managing the NODE_OPTIONS was performed using a series of regular expressions. These were prone to bugs, and have already caused a few issues. This moves us over to the standard parseArgs (docs):

import { parseArgs } from "node:utils"

Why?

This simplifies the argument parser dramatically, removing the need for any special patterns or accommodations. No need to maintain all these patterns when there's a lightweight built-in parser already available.

Fixes #53127
Fixes #53757
Fixes #47083
Fixes #50489
Closes #60919
Closes #59410
Closes NEXT-3219

wyattjoh · 2024-04-24T21:50:13Z

NODE_OPTIONS updates #65006 👈
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wyattjoh and the rest of your teammates on Graphite

ijjk · 2024-04-24T21:51:59Z

Tests Passed

ijjk · 2024-04-24T21:56:11Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js wyattjohnson/node-options-cleanup	Change
buildDuration	19.9s	18.3s	N/A
buildDurationCached	11.2s	8.4s	N/A
nodeModulesSize	238 MB	238 MB	⚠️ +41.4 kB
nextStartRea..uration (ms)	464ms	464ms	✓

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js wyattjohnson/node-options-cleanup	Change
2453-HASH.js gzip	31.5 kB	31.5 kB	N/A
3304.HASH.js gzip	169 B	169 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	N/A
8299-HASH.js gzip	5.09 kB	5.09 kB	✓
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	228 B	227 B	N/A
main-HASH.js gzip	31.5 kB	31.6 kB	N/A
webpack-HASH.js gzip	1.64 kB	1.65 kB	N/A
Overall change	50.5 kB	50.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js wyattjohnson/node-options-cleanup	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js wyattjohnson/node-options-cleanup	Change
_app-HASH.js gzip	193 B	194 B	N/A
_error-HASH.js gzip	193 B	191 B	N/A
amp-HASH.js gzip	510 B	510 B	✓
css-HASH.js gzip	342 B	343 B	N/A
dynamic-HASH.js gzip	2.51 kB	2.52 kB	N/A
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	365 B	364 B	N/A
hooks-HASH.js gzip	389 B	391 B	N/A
image-HASH.js gzip	4.28 kB	4.28 kB	N/A
index-HASH.js gzip	269 B	268 B	N/A
link-HASH.js gzip	2.68 kB	2.69 kB	N/A
routerDirect..HASH.js gzip	328 B	326 B	N/A
script-HASH.js gzip	395 B	397 B	N/A
withRouter-HASH.js gzip	323 B	323 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	1.2 kB	1.2 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js wyattjohnson/node-options-cleanup	Change
_buildManifest.js gzip	482 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js wyattjohnson/node-options-cleanup	Change
index.html gzip	527 B	530 B	N/A
link.html gzip	539 B	541 B	N/A
withRouter.html gzip	522 B	522 B	✓
Overall change	522 B	522 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js wyattjohnson/node-options-cleanup	Change
edge-ssr.js gzip	108 kB	108 kB	N/A
page.js gzip	3.05 kB	3.04 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js wyattjohnson/node-options-cleanup	Change
middleware-b..fest.js gzip	622 B	626 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	27.8 kB	27.8 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	839 B	839 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js wyattjohnson/node-options-cleanup	Change
app-page-exp...dev.js gzip	171 kB	171 kB	✓
app-page-exp..prod.js gzip	97.6 kB	97.6 kB	✓
app-page-tur..prod.js gzip	99.4 kB	99.4 kB	✓
app-page-tur..prod.js gzip	93.6 kB	93.6 kB	✓
app-page.run...dev.js gzip	145 kB	145 kB	✓
app-page.run..prod.js gzip	92.1 kB	92.1 kB	✓
app-route-ex...dev.js gzip	21.5 kB	21.5 kB	✓
app-route-ex..prod.js gzip	15.1 kB	15.1 kB	✓
app-route-tu..prod.js gzip	15.1 kB	15.1 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route.ru...dev.js gzip	21.2 kB	21.2 kB	✓
app-route.ru..prod.js gzip	14.9 kB	14.9 kB	✓
pages-api-tu..prod.js gzip	9.55 kB	9.55 kB	✓
pages-api.ru...dev.js gzip	9.82 kB	9.82 kB	✓
pages-api.ru..prod.js gzip	9.55 kB	9.55 kB	✓
pages-turbo...prod.js gzip	21.4 kB	21.4 kB	✓
pages.runtim...dev.js gzip	22.1 kB	22.1 kB	✓
pages.runtim..prod.js gzip	21.4 kB	21.4 kB	✓
server.runti..prod.js gzip	65.3 kB	65.3 kB	✓
Overall change	960 kB	960 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js wyattjohnson/node-options-cleanup	Change
0.pack gzip	1.61 MB	1.61 MB	⚠️ +678 B
index.pack gzip	107 kB	107 kB	N/A
Overall change	1.61 MB	1.61 MB	⚠️ +678 B

Diff details

Diff for middleware.js

Diff too large to display

Diff for image-HASH.js

@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [8358],
   {
-    /***/ 1552: /***/ (
+    /***/ 4070: /***/ (
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -9,7 +9,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/image",
         function () {
-          return __webpack_require__(5237);
+          return __webpack_require__(396);
         },
       ]);
       if (false) {
@@ -18,7 +18,7 @@
       /***/
     },
 
-    /***/ 2016: /***/ (module, exports, __webpack_require__) => {
+    /***/ 8490: /***/ (module, exports, __webpack_require__) => {
       "use strict";
       /* __next_internal_client_entry_do_not_use__  cjs */
       Object.defineProperty(exports, "__esModule", {
@@ -40,15 +40,15 @@
         __webpack_require__(422)
       );
       const _head = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(6074)
+        __webpack_require__(2457)
       );
-      const _getimgprops = __webpack_require__(9571);
-      const _imageconfig = __webpack_require__(6567);
-      const _imageconfigcontextsharedruntime = __webpack_require__(419);
-      const _warnonce = __webpack_require__(4486);
-      const _routercontextsharedruntime = __webpack_require__(162);
+      const _getimgprops = __webpack_require__(7932);
+      const _imageconfig = __webpack_require__(5706);
+      const _imageconfigcontextsharedruntime = __webpack_require__(9483);
+      const _warnonce = __webpack_require__(9035);
+      const _routercontextsharedruntime = __webpack_require__(4829);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(6996)
+        __webpack_require__(7240)
       );
       // This is replaced by webpack define plugin
       const configEnv = {
@@ -379,7 +379,7 @@
       /***/
     },
 
-    /***/ 9571: /***/ (
+    /***/ 7932: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -395,9 +395,9 @@
           return getImgProps;
         },
       });
-      const _warnonce = __webpack_require__(4486);
-      const _imageblursvg = __webpack_require__(133);
-      const _imageconfig = __webpack_require__(6567);
+      const _warnonce = __webpack_require__(9035);
+      const _imageblursvg = __webpack_require__(2642);
+      const _imageconfig = __webpack_require__(5706);
       const VALID_LOADING_VALUES =
         /* unused pure expression or super */ null && [
           "lazy",
@@ -772,7 +772,7 @@
       /***/
     },
 
-    /***/ 133: /***/ (__unused_webpack_module, exports) => {
+    /***/ 2642: /***/ (__unused_webpack_module, exports) => {
       "use strict";
       /**
        * A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -827,7 +827,7 @@
       /***/
     },
 
-    /***/ 4085: /***/ (
+    /***/ 503: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -854,10 +854,10 @@
         },
       });
       const _interop_require_default = __webpack_require__(7456);
-      const _getimgprops = __webpack_require__(9571);
-      const _imagecomponent = __webpack_require__(2016);
+      const _getimgprops = __webpack_require__(7932);
+      const _imagecomponent = __webpack_require__(8490);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(6996)
+        __webpack_require__(7240)
       );
       function getImageProps(imgProps) {
         const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -889,7 +889,7 @@
       /***/
     },
 
-    /***/ 6996: /***/ (__unused_webpack_module, exports) => {
+    /***/ 7240: /***/ (__unused_webpack_module, exports) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -924,7 +924,7 @@
       /***/
     },
 
-    /***/ 5237: /***/ (
+    /***/ 396: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -941,8 +941,8 @@
 
       // EXTERNAL MODULE: ./node_modules/.pnpm/[email protected]/node_modules/react/jsx-runtime.js
       var jsx_runtime = __webpack_require__(1527);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/[email protected][email protected]/node_modules/next/image.js
-      var next_image = __webpack_require__(1577);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/[email protected][email protected]/node_modules/next/image.js
+      var next_image = __webpack_require__(73);
       var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
       /* harmony default export */ const nextjs = {
         src: "/_next/static/media/nextjs.cae0b805.png",
@@ -972,12 +972,8 @@
       /***/
     },
 
-    /***/ 1577: /***/ (
-      module,
-      __unused_webpack_exports,
-      __webpack_require__
-    ) => {
-      module.exports = __webpack_require__(4085);
+    /***/ 73: /***/ (module, __unused_webpack_exports, __webpack_require__) => {
+      module.exports = __webpack_require__(503);
 
       /***/
     },
@@ -987,7 +983,7 @@
     /******/ var __webpack_exec__ = (moduleId) =>
       __webpack_require__((__webpack_require__.s = moduleId));
     /******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
-      __webpack_exec__(1552)
+      __webpack_exec__(4070)
     );
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;

Diff for 2453-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: f68f557

eps1lon · 2024-04-25T10:19:02Z

What's our policy on minimal Node.js version support and is parseArgs available in those versions?

timneutkens · 2024-04-25T10:23:06Z

https://nodejs.org/api/util.html#utilparseargsconfig

Added in: v18.3.0, v16.17.0

https://nextjs.org/blog/next-14#other-changes

Minimum Node.js version is now 18.17

Should be good 👍

SatsAllDay · 2024-04-26T00:54:57Z

Apologies in advance if this question has been answered elsewhere, at least in spirit. I am not familiar with next's release strategy.

It looks like this was first included in https://github.com/vercel/next.js/releases/tag/v14.3.0-canary.23 Does that mean this change will only be in versions 14.3+? Are changes like this ever back-ported to previous major releases such as 13.x, for example? I'm guessing not, but I wanted to confirm. The codebase in which I am eager to consume this change is using 13.x right now, so I am trying to figure out what kind of version bump will be required to leverage these updates.

Thank you in advance!

timneutkens · 2024-04-26T12:28:35Z

We cherry-pick commits from the canary branch to do patch releases on the 14.2 line, we don't backport these changes to 13.x currently.

You should be able to upgrade to Next.js 14, the only hard-breaking change we added in Next.js 14 is updating the minimum required Node.js version, which you should already be using Node.js 18 because 16 is end of life anyway.

SatsAllDay · 2024-04-26T13:41:51Z

Great, thank you very much for the detailed and prompt response!

feat: remove regexp for explicit argument parsing

51ab986

ijjk added created-by: Next.js team PRs by the Next.js team. tests type: next labels Apr 24, 2024

wyattjoh added 3 commits April 24, 2024 17:36

fix: fixed tests

b15c506

fix: linting

c7534e6

tests: fixed parsing of positional options

f68f557

wyattjoh marked this pull request as ready for review April 25, 2024 04:59

wyattjoh requested review from timneutkens, ijjk, shuding, samcx, huozhi, feedthejim and ztanner as code owners April 25, 2024 04:59

lubieowoce approved these changes Apr 25, 2024

View reviewed changes

timneutkens approved these changes Apr 25, 2024

View reviewed changes

timneutkens merged commit ab86fcf into canary Apr 25, 2024
80 checks passed

timneutkens deleted the wyattjohnson/node-options-cleanup branch April 25, 2024 10:23

SatsAllDay mentioned this pull request Apr 25, 2024

WIP: Support server-side debugging when running local in docker stackernews/stacker.news#450

Open

github-actions bot added the locked label May 11, 2024

github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NODE_OPTIONS updates #65006

NODE_OPTIONS updates #65006

wyattjoh commented Apr 24, 2024 •

edited

Loading

wyattjoh commented Apr 24, 2024

ijjk commented Apr 24, 2024 •

edited

Loading

ijjk commented Apr 24, 2024 •

edited

Loading

eps1lon commented Apr 25, 2024

timneutkens commented Apr 25, 2024

SatsAllDay commented Apr 26, 2024

timneutkens commented Apr 26, 2024

SatsAllDay commented Apr 26, 2024

NODE_OPTIONS updates #65006

NODE_OPTIONS updates #65006

Conversation

wyattjoh commented Apr 24, 2024 • edited Loading

What?

Why?

wyattjoh commented Apr 24, 2024

ijjk commented Apr 24, 2024 • edited Loading

Tests Passed

ijjk commented Apr 24, 2024 • edited Loading

Stats from current PR

eps1lon commented Apr 25, 2024

timneutkens commented Apr 25, 2024

SatsAllDay commented Apr 26, 2024

timneutkens commented Apr 26, 2024

SatsAllDay commented Apr 26, 2024

wyattjoh commented Apr 24, 2024 •

edited

Loading

ijjk commented Apr 24, 2024 •

edited

Loading

ijjk commented Apr 24, 2024 •

edited

Loading