Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update React from 14898b6a9 to c3048aab4 #64798

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Update React from 14898b6a9 to c3048aab4 #64798

merged 6 commits into from
Apr 25, 2024

Commits on Apr 24, 2024

  1. Ensure experimental versions don't use Canary release channel

    @eps1lon
    eps1lon committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    0e9134c View commit details
    Browse the repository at this point in the history

  2. Update React from 14898b6a9 to c3048aab4.

    @eps1lon
    eps1lon committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    5f5d5f4 View commit details
    Browse the repository at this point in the history

  3. Update warning messages

    @eps1lon
    eps1lon committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7d6640c View commit details
    Browse the repository at this point in the history

  4. Update onCaughtError interceptor 

    Would be nice to do this via onCaughtError but I copying the full impl of `defaultOnCaughtError` seems sketchy.
See https://vercel.slack.com/archives/C04TR3U872A/p1713969391445789 for quick proposal
    @eps1lon
    eps1lon committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4275064 View commit details
    Browse the repository at this point in the history

  5. Fix error overlay 

    Fixes displaying 2 errors in the redbox when just one was thrown.
It counted 2 because we had the actual error and React's "the above occured"
    @eps1lon
    eps1lon committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    fd04461 View commit details
    Browse the repository at this point in the history

  6. Ensure compiled React is not treated as an external 

    `next/dist/compiled/react-dom` can never appear in a require call i.e. be treated as an external because these modules don't import from vendored react-dom
but installed react-dom
    @eps1lon
    eps1lon committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    fbd6174 View commit details
    Browse the repository at this point in the history