-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify options passed to createWebpackAliases #57239
Merged
timneutkens
merged 1 commit into
canary
from
10-22-Simplify_options_passed_to_createWebpackAliases
Oct 23, 2023
Merged
Simplify options passed to createWebpackAliases #57239
timneutkens
merged 1 commit into
canary
from
10-22-Simplify_options_passed_to_createWebpackAliases
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi,
ztanner,
feedthejim and
a team
as code owners
October 23, 2023 03:35
This was referenced Oct 23, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
sokra
previously approved these changes
Oct 23, 2023
timneutkens
force-pushed
the
10-22-Simplify_options_passed_to_createWebpackAliases
branch
from
October 23, 2023 16:03
4f9ca1e
to
e41ebef
Compare
timneutkens
deleted the
10-22-Simplify_options_passed_to_createWebpackAliases
branch
October 23, 2023 16:04
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reducing the options so it becomes easier to call it outside of webpack-config.ts, which would be needed to pass it to Turbopack.