-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(next/image)!: mark domains
as deprecated in favor remotePatterns
#57062
Merged
kodiakhq
merged 6 commits into
canary
from
styfle/next-1692-mark-domains-as-deprecated-in-favor-of-remotepatterns
Oct 19, 2023
Merged
chore(next/image)!: mark domains
as deprecated in favor remotePatterns
#57062
kodiakhq
merged 6 commits into
canary
from
styfle/next-1692-mark-domains-as-deprecated-in-favor-of-remotepatterns
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
ztanner,
a team,
feedthejim and
wyattjoh
as code owners
October 19, 2023 16:15
styfle
requested review from
manovotny and
lydiahallie
and removed request for
a team
October 19, 2023 16:15
ijjk
added
area: documentation
examples
Issue/PR related to examples
created-by: Next.js team
PRs by the Next.js team.
type: next
labels
Oct 19, 2023
All broken links are now fixed, thank you! |
Stats from current PRDefault BuildGeneral Overall increase
|
vercel/next.js canary | vercel/next.js styfle/next-1692-mark-domains-as-deprecated-in-favor-of-remotepatterns | Change | |
---|---|---|---|
buildDuration | 11.6s | 11.6s | N/A |
buildDurationCached | 6.8s | 6.8s | N/A |
nodeModulesSize | 174 MB | 174 MB | |
nextStartRea..uration (ms) | 529ms | 532ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js styfle/next-1692-mark-domains-as-deprecated-in-favor-of-remotepatterns | Change | |
---|---|---|---|
199-HASH.js gzip | 27.5 kB | 27.5 kB | N/A |
3f784ff6-HASH.js gzip | 53.3 kB | 53.3 kB | ✓ |
99.HASH.js gzip | 182 B | 182 B | ✓ |
framework-HASH.js gzip | 45.3 kB | 45.3 kB | ✓ |
main-app-HASH.js gzip | 254 B | 251 B | N/A |
main-HASH.js gzip | 32.9 kB | 32.9 kB | N/A |
webpack-HASH.js gzip | 1.75 kB | 1.75 kB | N/A |
Overall change | 98.8 kB | 98.8 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js styfle/next-1692-mark-domains-as-deprecated-in-favor-of-remotepatterns | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js styfle/next-1692-mark-domains-as-deprecated-in-favor-of-remotepatterns | Change | |
---|---|---|---|
_app-HASH.js gzip | 206 B | 205 B | N/A |
_error-HASH.js gzip | 182 B | 180 B | N/A |
amp-HASH.js gzip | 506 B | 505 B | N/A |
css-HASH.js gzip | 322 B | 323 B | N/A |
dynamic-HASH.js gzip | 2.57 kB | 2.57 kB | N/A |
edge-ssr-HASH.js gzip | 260 B | 259 B | N/A |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 369 B | 369 B | ✓ |
image-HASH.js gzip | 4.36 kB | 4.36 kB | N/A |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.64 kB | 2.63 kB | N/A |
routerDirect..HASH.js gzip | 312 B | 311 B | N/A |
script-HASH.js gzip | 385 B | 384 B | N/A |
withRouter-HASH.js gzip | 307 B | 308 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 1.08 kB | 1.08 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js styfle/next-1692-mark-domains-as-deprecated-in-favor-of-remotepatterns | Change | |
---|---|---|---|
_buildManifest.js gzip | 484 B | 482 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js styfle/next-1692-mark-domains-as-deprecated-in-favor-of-remotepatterns | Change | |
---|---|---|---|
index.html gzip | 528 B | 530 B | N/A |
link.html gzip | 541 B | 542 B | N/A |
withRouter.html gzip | 523 B | 524 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js styfle/next-1692-mark-domains-as-deprecated-in-favor-of-remotepatterns | Change | |
---|---|---|---|
edge-ssr.js gzip | 93.7 kB | 93.7 kB | N/A |
page.js gzip | 155 kB | 155 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js styfle/next-1692-mark-domains-as-deprecated-in-favor-of-remotepatterns | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 623 B | 623 B | ✓ |
middleware-r..fest.js gzip | 150 B | 151 B | N/A |
middleware.js gzip | 22.5 kB | 22.5 kB | N/A |
edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
Overall change | 2.55 kB | 2.55 kB | ✓ |
balazsorban44
approved these changes
Oct 19, 2023
…d-in-favor-of-remotepatterns
Tests Passed |
…d-in-favor-of-remotepatterns
…d-in-favor-of-remotepatterns
kodiakhq
bot
deleted the
styfle/next-1692-mark-domains-as-deprecated-in-favor-of-remotepatterns
branch
October 19, 2023 20:24
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Next.js team
PRs by the Next.js team.
examples
Issue/PR related to examples
locked
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had
domains
as "not recommended" but this PR marks it as "deprecated" and prints a warning if its detected.I also updated all examples to switch from
domains
toremotePatterns
.