Skip to content

Fix build-native turbo config#53380

Merged
kodiakhq[bot] merged 2 commits intovercel:canaryfrom
ijjk:fix/build-native-turbo-config
Jul 31, 2023
Merged

Fix build-native turbo config#53380
kodiakhq[bot] merged 2 commits intovercel:canaryfrom
ijjk:fix/build-native-turbo-config

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented Jul 31, 2023

The turbo cache is currently not being invalidated for our build-native jobs when the root Cargo.lock is changed so #53308 never actually got re-built/applied in CI and tests are unexpectedly passing.

x-ref: slack thread

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Jul 31, 2023
@ijjk ijjk requested a review from styfle July 31, 2023 13:32
ijjk added a commit that referenced this pull request Jul 31, 2023
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Looks like I missed these in a previous PR:

@kodiakhq kodiakhq bot merged commit 0c70b9f into vercel:canary Jul 31, 2023
@ijjk ijjk deleted the fix/build-native-turbo-config branch July 31, 2023 14:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Next.js team PRs by the Next.js team. locked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants