Skip to content

Fix metadata routes prerender cache for standalone mode #49208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2023
Merged

Fix metadata routes prerender cache for standalone mode #49208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
494bd9e
Fix metadata routes prerender cache for standalone mode
huozhi May 4, 2023
7b65d30
Merge branch 'canary' into metadata/standalone
huozhi May 4, 2023
b370f1c
Merge branch 'canary' into metadata/standalone
huozhi May 4, 2023
f71704d
Merge branch 'canary' into metadata/standalone
huozhi May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/next/src/build/webpack/loaders/next-metadata-route-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,10 @@ const resourceUrl = new URL(import.meta.url)
const filePath = fileURLToPath(resourceUrl).replace(${JSON.stringify(
METADATA_RESOURCE_QUERY
)}, '')
const buffer = fs.readFileSync(filePath)

let buffer
export function GET() {
if (!buffer) { buffer = fs.readFileSync(filePath) }
return new NextResponse(buffer, {
headers: {
'Content-Type': contentType,
Expand Down
Binary file added test/production/standalone-mode/metadata/app/favicon.ico
View file
Open in desktop
Binary file not shown.
14 changes: 14 additions & 0 deletions test/production/standalone-mode/metadata/app/icon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions test/production/standalone-mode/metadata/app/layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
export default function Root({ children }) {
return (
<html>
<head></head>
<body>{children}</body>
</html>
)
}
3 changes: 3 additions & 0 deletions test/production/standalone-mode/metadata/app/page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default function page() {
return 'page'
}
22 changes: 22 additions & 0 deletions test/production/standalone-mode/metadata/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { createNextDescribe } from 'e2e-utils'

createNextDescribe(
'standalone mode - metadata routes',
{
files: __dirname,
},
({ next }) => {
beforeAll(async () => {
// Hide source files to make sure route.js can read files from source
// in order to hit the prerender cache
await next.renameFolder('app', 'app_hidden')
})

it('should work', async () => {
const faviconRes = await next.fetch('/favicon.ico')
const iconRes = await next.fetch('/icon.svg')
expect(faviconRes.status).toBe(200)
expect(iconRes.status).toBe(200)
})
}
)
6 changes: 6 additions & 0 deletions test/production/standalone-mode/metadata/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module.exports = {
output: 'standalone',
experimental: {
appDir: true,
},
}