-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Webpack 4 #4108
[WIP] Webpack 4 #4108
Conversation
Added a vendor chunk, holding react-dom and react + next.js specific files like the router, also in dev. But it didn't solve the singleton router issue. |
@timneutkens for vendor chunks, can we expose a settings override - may be an entry on |
@rashidul0405 I don't understand what you're asking 🤔. You can just use the |
@timneutkens Talking about this one: facebook/create-react-app#2206. In order to achieve this, for the current implementation, we will need to override whole |
just ability to pass which modules should end up into |
singleton router resolved here: |
@timneutkens please ignore my comments, I was checking server bundles and commented based on that. client side bundles are fine for now (all node_modules to main.js). |
Don't merge
Lets try to get next/router to function properly first before moving on to adding chunks etc.
Code that doesn't use
next/link
/next/router
runs fine.