Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update playwright version for CI #32048

Closed
wants to merge 5 commits into from
Closed

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 2, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Dec 2, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk ijjk added the type: next label Dec 2, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Dec 2, 2021

Failing test suites

Commit: d305799

test/integration/image-component/base-path/test/static.test.js

  • Static Image Component Tests for basePath > dev mode > Should allow an image with a static src to omit height and width
  • Static Image Component Tests for basePath > dev mode > Should use immutable cache-control header for static import
  • Static Image Component Tests for basePath > dev mode > Should automatically provide an image height and width
  • Static Image Component Tests for basePath > dev mode > Should allow provided width and height to override intrinsic
  • Static Image Component Tests for basePath > dev mode > Should add a blur placeholder to statically imported jpg
  • Static Image Component Tests for basePath > dev mode > Should add a blur placeholder to statically imported png
Expand output

● Static Image Component Tests for basePath › dev mode › Should allow an image with a static src to omit height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:35829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should use immutable cache-control header for static import

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:35829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should automatically provide an image height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:35829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should allow provided width and height to override intrinsic

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:35829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should add a blur placeholder to statically imported jpg

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:35829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should add a blur placeholder to statically imported png

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:35829/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

@ijjk
Copy link
Member Author

ijjk commented Dec 2, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/playwright Change
buildDuration 24.8s 25.2s ⚠️ +365ms
buildDurationCached 4.5s 4.5s -6ms
nodeModulesSize 347 MB 347 MB -954 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/playwright Change
/ failed reqs 0 0
/ total time (seconds) 4.07 4.134 ⚠️ +0.06
/ avg req/sec 614.19 604.78 ⚠️ -9.41
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.15 2.175 ⚠️ +0.02
/error-in-render avg req/sec 1162.81 1149.63 ⚠️ -13.18
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/playwright Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/playwright Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/playwright Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/playwright Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/playwright Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/playwright Change
buildDuration 26.8s 26.9s ⚠️ +65ms
buildDurationCached 4.4s 4.5s ⚠️ +45ms
nodeModulesSize 347 MB 347 MB -954 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/playwright Change
/ failed reqs 0 0
/ total time (seconds) 4.141 4.175 ⚠️ +0.03
/ avg req/sec 603.72 598.77 ⚠️ -4.95
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.244 2.078 -0.17
/error-in-render avg req/sec 1114.12 1202.86 +88.74
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/playwright Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/playwright Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/playwright Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/playwright Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/playwright Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 1dd7d1a

@ijjk
Copy link
Member Author

ijjk commented Dec 2, 2021

Closing in favor of separate PRs, continued in #32057

@ijjk ijjk closed this Dec 2, 2021
@ijjk ijjk deleted the update/playwright branch December 2, 2021 17:37
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant