Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add missing ua type for NextRequest #31901

Merged
merged 3 commits into from
Nov 30, 2021
Merged

fix(types): add missing ua type for NextRequest #31901

merged 3 commits into from
Nov 30, 2021

Conversation

j-mendez
Copy link
Contributor

add missing ua string type on NextRequest["ua"], returns full agent as string

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

add missing ua string type on NextRequest["ua"], returns full agent as string
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I went ahead and updated to not extend the IResult type as it seems this type isn't available correctly by default (which should have included ua if it was).

@ijjk
Copy link
Member

ijjk commented Nov 30, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary j-mendez/next.js patch-1 Change
buildDuration 18.2s 18.1s -26ms
buildDurationCached 3.3s 3.4s ⚠️ +16ms
nodeModulesSize 347 MB 347 MB ⚠️ +228 B
Page Load Tests Overall increase ✓
vercel/next.js canary j-mendez/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.873 2.925 ⚠️ +0.05
/ avg req/sec 870.23 854.76 ⚠️ -15.47
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.393 1.345 -0.05
/error-in-render avg req/sec 1794.37 1858.54 +64.17
Client Bundles (main, webpack, commons)
vercel/next.js canary j-mendez/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary j-mendez/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary j-mendez/next.js patch-1 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary j-mendez/next.js patch-1 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary j-mendez/next.js patch-1 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary j-mendez/next.js patch-1 Change
buildDuration 19.7s 19.6s -72ms
buildDurationCached 3.4s 3.4s -7ms
nodeModulesSize 347 MB 347 MB ⚠️ +228 B
Page Load Tests Overall increase ✓
vercel/next.js canary j-mendez/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.896 2.985 ⚠️ +0.09
/ avg req/sec 863.37 837.52 ⚠️ -25.85
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.367 1.341 -0.03
/error-in-render avg req/sec 1829.22 1864.48 +35.26
Client Bundles (main, webpack, commons)
vercel/next.js canary j-mendez/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary j-mendez/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary j-mendez/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary j-mendez/next.js patch-1 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary j-mendez/next.js patch-1 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: a686525

@ijjk ijjk merged commit a2fa637 into vercel:canary Nov 30, 2021
@j-mendez j-mendez deleted the patch-1 branch December 1, 2021 22:17
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants