Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native unit tests #29146

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Fix native unit tests #29146

merged 1 commit into from
Sep 16, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Sep 16, 2021

There's some weirdness with the test fixture and whitespace/semi colons that we need to look into, but this will make the tests happy for now.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Sep 16, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
buildDuration 14.3s 14.4s ⚠️ +70ms
buildDurationCached 3.7s 3.7s ⚠️ +56ms
nodeModulesSize 182 MB 182 MB
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
/ failed reqs 0 0
/ total time (seconds) 3.046 3.008 -0.04
/ avg req/sec 820.87 831.03 +10.16
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.525 1.461 -0.06
/error-in-render avg req/sec 1639.2 1711.62 +72.42
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.7 kB 26.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.6 kB 70.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
index.html gzip 540 B 540 B
link.html gzip 552 B 552 B
withRouter.html gzip 535 B 535 B
Overall change 1.63 kB 1.63 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
buildDuration 7.3s 7.3s ⚠️ +30ms
buildDurationCached 3.5s 3.5s
nodeModulesSize 182 MB 182 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
/ failed reqs 0 0
/ total time (seconds) 2.998 3.042 ⚠️ +0.04
/ avg req/sec 833.76 821.94 ⚠️ -11.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.468 1.53 ⚠️ +0.06
/error-in-render avg req/sec 1702.56 1634.49 ⚠️ -68.07
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
264.HASH.js gzip 179 B 179 B
675-HASH.js gzip 13.8 kB 13.8 kB
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.6 kB 34.6 kB
webpack-HASH.js gzip 1.65 kB 1.65 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
_app-HASH.js gzip 1.32 kB 1.32 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 330 B 330 B
dynamic-HASH.js gzip 2.8 kB 2.8 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 638 B 638 B
image-HASH.js gzip 575 B 575 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 327 B 327 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 323 B 323 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
_buildManifest.js gzip 512 B 512 B
Overall change 512 B 512 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js fix/native-unit-test Change
index.html gzip 538 B 538 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: 6833a53

@ijjk ijjk merged commit 16a737d into vercel:canary Sep 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants