Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to webpack 5.50.0 #27929

Merged
merged 2 commits into from
Aug 10, 2021
Merged

update to webpack 5.50.0 #27929

merged 2 commits into from
Aug 10, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Aug 10, 2021

  • performance improvements for cache serialization
  • disabled cache compression by default (next.js is using webpack default again)
  • support hashbang

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Does this also solve the hashbang issue here? #27906

@sokra
Copy link
Member Author

sokra commented Aug 10, 2021

Does this also solve the hashbang issue here? #27906

yes

@sokra
Copy link
Member Author

sokra commented Aug 10, 2021

Maybe we can change the other PR to only add the test cases, which are good to have.

@ijjk
Copy link
Member

ijjk commented Aug 10, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 13.8s 13.7s -141ms
buildDurationCached 3.2s 3.2s ⚠️ +17ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +1.07 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
/ failed reqs 0 0
/ total time (seconds) 2.482 2.509 ⚠️ +0.03
/ avg req/sec 1007.36 996.51 ⚠️ -10.85
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.405 1.445 ⚠️ +0.04
/error-in-render avg req/sec 1778.88 1730.21 ⚠️ -48.67
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.12 kB 4.12 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 490 B 490 B
Overall change 490 B 490 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/upgrade Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 523 B 523 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 11.3s 11.5s ⚠️ +184ms
buildDurationCached 4.5s 4.7s ⚠️ +223ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +1.07 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/upgrade Change
/ failed reqs 0 0
/ total time (seconds) 2.464 2.44 -0.02
/ avg req/sec 1014.54 1024.47 +9.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.38 1.338 -0.04
/error-in-render avg req/sec 1811.59 1868.58 +56.99
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/upgrade Change
index.html gzip 577 B 577 B
link.html gzip 589 B 589 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: c8f84ed

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
* performance improvements for cache serialization
* disabled cache compression by default (next.js is using webpack default again)
* support hashbang
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants