Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persistent cache need to be invalidated when source-maps are enabled #27607

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 29, 2021

No description provided.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jul 29, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
buildDuration 12.7s 12.4s -211ms
buildDurationCached 2.8s 2.9s ⚠️ +37ms
nodeModulesSize 50.3 MB 50.3 MB ⚠️ +188 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
/ failed reqs 0 0
/ total time (seconds) 2.197 2.19 -0.01
/ avg req/sec 1137.72 1141.37 +3.65
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.126 1.217 ⚠️ +0.09
/error-in-render avg req/sec 2220.1 2054.58 ⚠️ -165.52
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 22.8 kB 22.8 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 66.7 kB 66.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 4.1 kB 4.1 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
_buildManifest.js gzip 490 B 490 B
Overall change 490 B 490 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
buildDuration 9.9s 10.3s ⚠️ +367ms
buildDurationCached 4.4s 3.7s -715ms
nodeModulesSize 50.3 MB 50.3 MB ⚠️ +188 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
/ failed reqs 0 0
/ total time (seconds) 2.203 2.245 ⚠️ +0.04
/ avg req/sec 1134.61 1113.79 ⚠️ -20.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.199 1.213 ⚠️ +0.01
/error-in-render avg req/sec 2085.41 2060.22 ⚠️ -25.19
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 13.8 kB 13.8 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.7 kB 67.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.94 kB 2.94 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
_buildManifest.js gzip 499 B 499 B
Overall change 499 B 499 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/cache-source-map Change
index.html gzip 577 B 577 B
link.html gzip 589 B 589 B
withRouter.html gzip 569 B 569 B
Overall change 1.74 kB 1.74 kB
Commit: a5ef079

@kodiakhq kodiakhq bot merged commit fabaaa9 into canary Jul 29, 2021
@kodiakhq kodiakhq bot deleted the bugfix/cache-source-map branch July 29, 2021 16:59
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants