Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure generateBuildId is not required in config type #27443

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 23, 2021

This ensures none of the top-level config fields are required as this type is public and can be used for type checking now.

Fixes: #27428

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member Author

ijjk commented Jul 23, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/config-type Change
buildDuration 15.4s 15.7s ⚠️ +279ms
buildDurationCached 3.6s 3.5s -103ms
nodeModulesSize 49.5 MB 49.5 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/config-type Change
/ failed reqs 0 0
/ total time (seconds) 2.723 2.639 -0.08
/ avg req/sec 918.05 947.35 +29.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.448 1.432 -0.02
/error-in-render avg req/sec 1726.9 1746.17 +19.27
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/config-type Change
359.HASH.js gzip 2.96 kB 2.96 kB
745.HASH.js gzip 180 B 180 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 21 kB 21 kB
webpack-HASH.js gzip 1.53 kB 1.53 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/config-type Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/config-type Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 554 B 554 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 2.28 kB 2.28 kB
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.63 kB 5.63 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.1 kB 19.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/config-type Change
_buildManifest.js gzip 489 B 489 B
Overall change 489 B 489 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/config-type Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js fix/config-type Change
buildDuration 12.5s 12.5s ⚠️ +45ms
buildDurationCached 4.8s 4.8s -76ms
nodeModulesSize 49.5 MB 49.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/config-type Change
/ failed reqs 0 0
/ total time (seconds) 2.583 2.616 ⚠️ +0.03
/ avg req/sec 967.88 955.61 ⚠️ -12.27
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.478 1.501 ⚠️ +0.02
/error-in-render avg req/sec 1691.89 1665.49 ⚠️ -26.4
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/config-type Change
17.HASH.js gzip 2.98 kB 2.98 kB
18.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 13.8 kB 13.8 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 8.4 kB 8.4 kB
webpack-HASH.js gzip 1.22 kB 1.22 kB
Overall change 68.5 kB 68.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/config-type Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/config-type Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.76 kB 3.76 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.02 kB 3.02 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.6 kB 17.6 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/config-type Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/config-type Change
index.html gzip 577 B 577 B
link.html gzip 589 B 589 B
withRouter.html gzip 569 B 569 B
Overall change 1.74 kB 1.74 kB
Commit: ec5e7c9

@ijjk ijjk merged commit a8b9c3a into vercel:canary Jul 23, 2021
@ijjk ijjk deleted the fix/config-type branch July 23, 2021 17:14
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import('next').NextConfig has required generateBuildId property
2 participants